Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrival delay to departure delay to get accurate simulation on delayed trains #16

Open
findus opened this issue Sep 22, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request partially fixed

Comments

@findus
Copy link
Owner

findus commented Sep 22, 2020

As soon as a train departs from a station, all new datasets from hafas omit the prior station departure delays. That causes all future sections to be misaligned because the simulation thinks that passing the following section between 2 stops will take the "normal" time + the delay:

Dep (18:00)+50 -------> Arr (19:00)+50 = Travel time: 60 minutes
Omitted:
Dep (18:00) --------> Arr (19:00)+50 = Travel time: 1h 50minutes

Fix: Add the arrival delay to the departure delay.

@findus findus added the bug Something isn't working label Sep 22, 2020
@findus
Copy link
Owner Author

findus commented Sep 24, 2020

Tried to fix it with 1.3.3, now the first occuring delay gets "backported" to all prior stops.
Still need to find a way to get at least the "real" departure date from the latest station the train departed on, might switch or modify the backend for this.

@findus findus added enhancement New feature or request bug Something isn't working partially fixed and removed bug Something isn't working labels Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request partially fixed
Projects
None yet
Development

No branches or pull requests

1 participant