Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analogy interface is too inflexible #122

Open
danieldk opened this issue Nov 13, 2019 · 0 comments
Open

Analogy interface is too inflexible #122

danieldk opened this issue Nov 13, 2019 · 0 comments
Assignees
@danieldk @sebpuetz @RealNicolasBourbaki

Comments

@danieldk
Copy link
Member

While reimplementing finalfusion-inspector in Rust, I bumped into a small annoyance. The analogy method takes an array of &str:

query: [&str; 3]

However, oftentimes you have a [String; 3]. We should relax this type to:

query: [impl AsRef<str>; 3]

This should not break the API, since it allows a superset of types of the original signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieldk danieldk

@sebpuetz sebpuetz

@RealNicolasBourbaki RealNicolasBourbaki

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danieldk @sebpuetz @RealNicolasBourbaki