Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ version printed as blank ootb #32

Open
vadi2 opened this issue Jan 21, 2022 · 2 comments
Open

C++ version printed as blank ootb #32

vadi2 opened this issue Jan 21, 2022 · 2 comments
Assignees
Labels
acknowledged The issue is being worked on bug Something isn't working

Comments

@vadi2
Copy link
Contributor

vadi2 commented Jan 21, 2022

Getting this in the logs:

[cmake] -- Applied compiler warnings. Using standard .

@vadi2
Copy link
Contributor Author

vadi2 commented Jan 22, 2022

This could be fixed with:

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

Using the latest published standard would make sense for a greenfield C++ project.

@filipdutescu filipdutescu self-assigned this May 17, 2022
@filipdutescu filipdutescu added bug Something isn't working acknowledged The issue is being worked on labels May 17, 2022
@filipdutescu
Copy link
Owner

Awesome catch! Thanks for providing a solution as well. Will work to merge it in the next couple of weeks, alongside the other issues and create a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged The issue is being worked on bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants