Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(deps): update dependency chai to v5 (#263)" #264

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

MuckT
Copy link
Contributor

@MuckT MuckT commented Jan 2, 2024

Reverts Chai upgrade as it only supports greater than Node 18 - Chai 5.x.

Copy link
Contributor

@satish-ravi satish-ravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just upgrade to node 20 and get chai 5 working? If not, we should at least have chai upgrades blocked, because otherwise immediately after this merges, another chai v5 upgrade PR will be merged by renovate.. Ideally our CI should not allow chai v5 being merged, but I guess we don't have any chai usages in CI.

@MuckT
Copy link
Contributor Author

MuckT commented Jan 2, 2024

Upgrading to Node 20 seems like the best course of action. Looks like this gets a bit more complicated with Chai v5: chaijs/chai#1569.

@MuckT MuckT merged commit bb5b22c into main Jan 3, 2024
1 check passed
@MuckT MuckT deleted the revert-263-renovate/major-test-packages branch January 3, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants