Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANs Logic changes #359

Open
Pasarus opened this issue Feb 7, 2025 · 0 comments
Open

SANs Logic changes #359

Pasarus opened this issue Feb 7, 2025 · 0 comments
Assignees

Comments

@Pasarus
Copy link
Member

Pasarus commented Feb 7, 2025

Presently we are working just based of titles. This logic is not ideal and currently leads to lots of excess changes. The logic at present is:

  • If {x}_{y}_SANS/TRANS then scatter file
  • If {x}_TRANS then Transmission file
  • If {direct}_TRANS then direct beam for both Scatter and canister
  • If {y}_SANS/TRANS then scatter for canister i.e. background
  • If {y}_TRANS then Transmission for canister

The logic should be:

  • If file is SANs, find the trans and direct, then if they exist then reduce.
  • If file is TRANs, find the SANs and direct, if they exist then reduce.
  • Canister/Background is defined by having a value in the second braces like the previous logic.
  • When a Canister is not supplied, use the direct SANS and TRANS for runs without a second set of braces.
  • How to find the direct file:
    • Compare direct files from this cycle that contain mt, direct, or empty in the title.
    • Take those files, and check if the values align between it and the scatter file in the sample logs:
      • LOQ:
        • Aperture
      • SANs2D (max difference of 2mm):
        • G1-6
        • S1-6
        • Rear Detector Z
        • Front Detector Z
        • JAW_E, JAW_N, JAW_S, and JAW_W
      • Zoom (max diff 1mm):
        • Detector Z
        • JAW1_N, JAW1_E, JAW1_S, JAW1_W, JAW2_N .... JAW4_N, JAW4_E, JAW4_S, and JAW4_W
        • PGC_Unit

Instead of using the Journal every time we get a file and reconstructing the SANsFileData dataclass in rundetection, should we just maintain it? Then if we restart the pod we call out to the Journal and reconstruct it before we are ready to do more message processing.

@Pasarus Pasarus self-assigned this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant