Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated calls to routing mapper #141

Merged

Conversation

etiennebarrie
Copy link
Contributor

@stevenharman
Copy link
Collaborator

Thanks for the contribution, @etiennebarrie. If I'm following the linked PRs correctly, this deprecation won't take place until Rails 8.0. And the keyword based API (using to: and at:) has been supported for… a long time! Meaning our existing dependency constraints on railties >= 6.1 should be fine.

If all of that is correct, this is 👍 for me.

@etiennebarrie
Copy link
Contributor Author

Oh sorry I forgot to add some details. Yes this is what I found as well, to:, at: have been here for a long time, no risk on backwards compatibility. 👍

Yes Rails 8.0 will deprecate this syntax. Some of us run Rails main in production 😇

@stevenharman stevenharman merged commit 9e89fa1 into fgrehm:master Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants