Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff_schedule() for mfl conenctions throws error #442

Open
jak3sch opened this issue Dec 8, 2024 · 3 comments
Open

ff_schedule() for mfl conenctions throws error #442

jak3sch opened this issue Dec 8, 2024 · 3 comments

Comments

@jak3sch
Copy link
Contributor

jak3sch commented Dec 8, 2024

Describe the bug
If I'm using ff_schedule() with a mfl connection I get:
Error in (!is.na(full_schedule$spread) | full_schedule$spread == 0) && : 'length = 960' in coercion to 'logical(1)'

I tracked down this issue to the file mfl_schedule.R on lines 80-83 but I don't know how to fix this.

Reprex

ffscrapr::ff_schedule(ffscrapr::mfl_connect(2024, 63018))
#> Error in (!is.na(full_schedule$spread) | full_schedule$spread == 0) && : 'length = 960' in coercion to 'logical(1)'

Expected behavior
The function should return a dataframe with the schedule data of my fantasyleague.

Session information
Please copy the output of ffscrapr::ffverse_sitrep() into the box below.

── System Info ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.4.1 (2024-06-14 ucrt) • Running under: Windows 11 x64 (build 22631)
── Package Status ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   package installed  cran      dev behind
1 ffscrapr     1.4.8 1.4.8 1.4.8.20    dev
── Package Options ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass    (1.2.0)   • jsonlite   (1.8.9)  • stringr    (1.5.1)  
• assertthat (0.2.1)   • lifecycle  (1.0.4)  • sys        (3.4.2)  
• backports  (1.5.0)   • magrittr   (2.0.3)  • tibble     (3.2.1)  
• cachem     (1.1.0)   • memoise    (2.0.1)  • tidyr      (1.3.1)  
• checkmate  (2.3.2)   • mime       (0.12)   • tidyselect (1.2.1)  
• cli        (3.6.3)   • nflreadr   (1.4.1)  • utf8       (1.2.4)  
• cpp11      (0.5.0)   • openssl    (2.2.2)  • vctrs      (0.6.5)  
• curl       (5.2.3)   • pillar     (1.9.0)  • withr      (3.0.1)  
• data.table (1.16.0)  • pkgconfig  (2.0.3)  • graphics   (4.4.1)  
• dplyr      (1.1.4)   • purrr      (1.0.2)  • grDevices  (4.4.1)  
• fansi      (1.0.6)   • R6         (2.5.1)  • methods    (4.4.1)  
• fastmap    (1.2.0)   • rappdirs   (0.3.3)  • stats      (4.4.1)  
• generics   (0.1.3)   • ratelimitr (0.4.1)  • tools      (4.4.1)  
• glue       (1.7.0)   • rlang      (1.1.4)  • utils      (4.4.1)  
• httr       (1.4.7)   • stringi    (1.8.4)    
── Not Installed ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• ffsimulatorffprosffopportunity  
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@tanho63
Copy link
Member

tanho63 commented Dec 8, 2024

Can you install the latest development version?

install.packages("ffscrapr", repos = c("https://ffverse.r-universe.dev", getOption("repos")))

@jak3sch
Copy link
Contributor Author

jak3sch commented Dec 8, 2024

Yes, that seems to fix it. Is there a timeline for a release in to the main release?

@tanho63
Copy link
Member

tanho63 commented Dec 9, 2024

Not yet, the tests need some work to deal with CRAN updates which I just haven’t found time for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants