Make Sass implementation agnostic ( supporting dart-sass ) #17
+63
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsubal
commented
Oct 8, 2018
| }) | ||
| }) | ||
| }) | ||
| describe.each(['node-sass', 'sass'])('with require("%s")', function(impl) { |
There was a problem hiding this comment.
Currently installed version of jest did not support describe.each, so I updated jest
There was a problem hiding this comment.
Just for the record, the test failure was not due to the jest version ( it also failed with [email protected] with ['node-sass', 'sass'].forEach instead of describe.each )
|
Love this, can we get it merged @koenpunt ? |
koenpunt
reviewed
Aug 31, 2023
| options = options || {} | ||
| options.images_path = __dirname + '/images' | ||
| options.fonts_path = __dirname + '/fonts' | ||
| options.implemantation = sass |
There was a problem hiding this comment.
Suggested change
| options.implemantation = sass | |
| options.implementation = sass |
|
hey folks, can this PR get merged in? would be super helpful since node-sass is basically decrepit at this point |
|
for those who want to install this now |
|
I've released a new version to npm that replaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #16
I made this library to be sass-implementation agnostic, that means, add support for
dart-sass.With these changes, node-sass-asset-functions now accepts
implementationoption ( which exceptsrequire('node-sass')orrequire('sass'), and when absent it will be implicitlynode-sass)For some reason the test is not passing ( Maybe
dart-sasscannot read file correctly, even though the path looks correct ), which is now I'm searching why... Help wanted by someone.