Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose milestone comparison precision to user #933

Open
RemDelaporteMathurin opened this issue Jan 3, 2025 · 0 comments
Open

Expose milestone comparison precision to user #933

RemDelaporteMathurin opened this issue Jan 3, 2025 · 0 comments
Labels
fenicsx Issue that is related to the fenicsx support

Comments

@RemDelaporteMathurin
Copy link
Collaborator

Right now when adapting the stepsize and checking for milestones, we use the default relative tolerance (rtol) in np.isclose.

This value is 1e-5 according to the documentation.

This means that milestones t = 100000.5 will be missed if t = 100000...

A solution would be to expose the rtol argument of np.isclose in the stepsize parameters
@RemDelaporteMathurin RemDelaporteMathurin added the fenicsx Issue that is related to the fenicsx support label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fenicsx Issue that is related to the fenicsx support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RemDelaporteMathurin