Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim Down the Dependencies #110

Open
zachcp opened this issue Jan 7, 2025 · 0 comments
Open

Slim Down the Dependencies #110

zachcp opened this issue Jan 7, 2025 · 0 comments
Assignees

Comments

@zachcp
Copy link
Collaborator

zachcp commented Jan 7, 2025

As of v0.1.0 the builds take over 10 minutes. This is due to the rather large dependency tree. There are a few ways to slim down the tree.

  1. Remove Bevy.
    • This is at the top level to make dependency handling understandable but leads to large builds. I wanted to keep all of the creates connected until we get a bit further on the selection API. If this continues to be burdensome, we can move this dep out of the workspace. That will help but won't fully solve the problem.
  2. Remove ORT/ndarray
    • I am using ORT as a wrapper for the ONNX runtime but it turns out that Candle also has an ONNX-wrapper in candle_onnx.
    • main blocker is my initial test led to an inexplicable dimension error
  3. Remove ndarray-safetensor
    • I am using ndarray-safetensor to serialize between the Candle and ORT/ndarray ecosystems. Fixing 2 will eliminate 3 but if I can serialize directly to NDARRY without going through this library that will dave a dep. Code in ferritin-onnx-models/src/utilities.rs
@zachcp zachcp self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant