Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check consistency in gtbin of input events list with parameters #2

Open
jasercion opened this issue Mar 23, 2020 · 0 comments
Open
Assignees

Comments

@jasercion
Copy link
Contributor

migrated from STGEN-166

gtbin should check that the selections applied to the input events list prior to calling gtbin cover the space required for the projection.
This means:

  • check that the spatial selection covers the square defined by the nxpix, nypix, binsz, coordsys, xref, yref, axisrot, proj parameters (this is non trivial for general projections)
  • check that the energy selection covers the interval defined by the ebinalg, emin, emax, enumbins parameters (this is trivial)

When those conditions are not met, the output will be unsuitable for scientific analysis and the user should at least get a warning.
My preferred solution would be to throw an error by default and add a parameter (such as checkselection) which could be set to no voluntarily by the user who wants to override the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants