Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect arguments provided to the scoring function #1

Open
Grobnar opened this issue Aug 8, 2023 · 0 comments · May be fixed by #2
Open

Incorrect arguments provided to the scoring function #1

Grobnar opened this issue Aug 8, 2023 · 0 comments · May be fixed by #2

Comments

@Grobnar
Copy link

Grobnar commented Aug 8, 2023

Hi, I noticed the call to the scoring function in path_finder_find_step reverses the col and row arguments.

path_finder->f_score[n] = path_finder->f_score[n] + path_finder->score_func(path_finder, n / path_finder->cols, n % path_finder->cols, data);
Looks like it should be:
path_finder->f_score[n] = path_finder->f_score[n] + path_finder->score_func(path_finder, n % path_finder->cols, n / path_finder->cols, data);
Just switching the modulus and division.

As a sidenote, great work, I find your code really clean and simple and have been trying to model mine after it since using your library.

mstratman added a commit to mstratman/uastar that referenced this issue Apr 17, 2024
@mstratman mstratman linked a pull request Apr 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant