naming convention and let it crash

Author: Felix Van der Jeugt

src/NumberSix/Handlers/Weather.hs

@@ -2,7 +2,7 @@
 {-# LANGUAGE OverloadedStrings #-}
 module NumberSix.Handlers.Weather
     ( handler
-    , get_weather
+    , getWeather
     , Weather (..)
     , Temperature (..)
     ) where
@@ -75,8 +75,8 @@ instance Show Description where
 
 
 --------------------------------------------------------------------------------
-get_weather :: Text -> IO (Maybe Weather)
-get_weather query = do
+getWeather :: Text -> IO (Maybe Weather)
+getWeather query = do
     result <- ((parseJsonEither <$> http url id) :: IO (Either String Weather))
         `catch` (\ex -> return $ Left $ show (ex :: HttpException))
     either (const $ return Nothing) (return . Just) result
@@ -88,7 +88,7 @@ get_weather query = do
 --------------------------------------------------------------------------------
 weather :: Text -> IO Text
 weather query = do
-    result <- get_weather query
+    result <- getWeather query
     maybe randomError (return . pprint) result
   where
     pprint :: Weather -> Text

tests/NumberSix/Handlers/Weather/Tests.hs

@@ -6,7 +6,7 @@ module NumberSix.Handlers.Weather.Tests
 
 
 --------------------------------------------------------------------------------
-import           Data.Maybe                 (fromJust, isJust)
+import           Data.Maybe                 (fromJust)
 import           Test.Framework             (Test, testGroup)
 import           Test.HUnit                 (assert)
 
@@ -22,8 +22,7 @@ tests :: Test
 tests = testGroup "NumberSix.Handlers.Weather.Tests"
     [ cases "weather"
         [ do
-            result <- get_weather "gent"
-            assert $ isJust result
+            result <- getWeather "gent"
             let (Weather (Temperature t) _) = fromJust result
             assert $ -15 <= t && t <= 60
         ]