Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libzip links with external libs found on host #6

Open
3 tasks done
prudhomm opened this issue Oct 26, 2024 · 0 comments · Fixed by spack/spack#47230 or #7
Open
3 tasks done

libzip links with external libs found on host #6

prudhomm opened this issue Oct 26, 2024 · 0 comments · Fixed by spack/spack#47230 or #7
Assignees
@prudhomm
Labels
bug Something isn't working

Comments

@prudhomm
Copy link
Member

Steps to reproduce

$ spack install libzip

Error message

we might get linking issues if we have an environment having openssl and libzip and ssl is installed with another version on the host such as #12

Information on your system

libzip enable by default a few libs https://github.com/nih-at/libzip/blob/main/CMakeLists.txt by default

option(ENABLE_COMMONCRYPTO "Enable use of CommonCrypto" ON)
option(ENABLE_GNUTLS "Enable use of GnuTLS" ON)
option(ENABLE_MBEDTLS "Enable use of mbed TLS" ON)
option(ENABLE_OPENSSL "Enable use of OpenSSL" ON)
option(ENABLE_WINDOWS_CRYPTO "Enable use of Windows cryptography libraries" ON)

option(ENABLE_BZIP2 "Enable use of BZip2" ON)
option(ENABLE_LZMA "Enable use of LZMA" ON)
option(ENABLE_ZSTD "Enable use of Zstandard" ON)

I suggest to be enable to enable/disable them and have then enabled by default using variants

General information

  • I have run spack debug report and reported the version of Spack/Python/Platform
  • I have searched the issues of this repo and believe this is not a duplicate
  • I have run the failing commands in debug mode and reported the output
@prudhomm prudhomm added the bug Something isn't working label Oct 26, 2024
@prudhomm prudhomm self-assigned this Oct 26, 2024
prudhomm added a commit that referenced this issue Oct 26, 2024
@prudhomm
libzip links with external libs found on host #6
001ba7e
This was referenced Oct 26, 2024
Merged
Merged
@prudhomm prudhomm linked a pull request Oct 26, 2024 that will close this issue
bug libzip: links with external libs found on host and new version #7
Merged
@prudhomm prudhomm reopened this Oct 26, 2024
@prudhomm prudhomm mentioned this issue Oct 28, 2024
Open
wdconinc added a commit to spack/spack that referenced this issue Dec 22, 2024
@prudhomm @wdconinc
libzip: links with external libs found on host and new version (#47230)
9554f88 
* libzip links with external libs found on host feelpp#6

* add maintainers

* fix style

* use multi-build system

/cc @wdconinc

* fix style

* rm space and rename variant bz2 to bzip2

/cc @wdconinc

* fix variant name for bzip2

* zstd is supported in libzip@:1.8

* fix style

* fix style

* fix style

* rm deprecated version and versions that cannot be found easily

use only cmake from now on

* fix style

* fix style

* use variant when option for zstd

* Update var/spack/repos/builtin/packages/libzip/package.py

Co-authored-by: Wouter Deconinck <[email protected]>

* fix style

/cc @wdconinc

---------

Co-authored-by: Wouter Deconinck <[email protected]>
tdrwenski pushed a commit to tdrwenski/spack that referenced this issue Dec 26, 2024
@prudhomm @wdconinc @tdrwenski
libzip: links with external libs found on host and new version (spack…
6d58a97 
…#47230)

* libzip links with external libs found on host feelpp#6

* add maintainers

* fix style

* use multi-build system

/cc @wdconinc

* fix style

* rm space and rename variant bz2 to bzip2

/cc @wdconinc

* fix variant name for bzip2

* zstd is supported in libzip@:1.8

* fix style

* fix style

* fix style

* rm deprecated version and versions that cannot be found easily

use only cmake from now on

* fix style

* fix style

* use variant when option for zstd

* Update var/spack/repos/builtin/packages/libzip/package.py

Co-authored-by: Wouter Deconinck <[email protected]>

* fix style

/cc @wdconinc

---------

Co-authored-by: Wouter Deconinck <[email protected]>
kshea21 pushed a commit to kshea21/spack that referenced this issue Dec 26, 2024
@prudhomm @wdconinc @kshea21
libzip: links with external libs found on host and new version (spack…
6a21234 
…#47230)

* libzip links with external libs found on host feelpp#6

* add maintainers

* fix style

* use multi-build system

/cc @wdconinc

* fix style

* rm space and rename variant bz2 to bzip2

/cc @wdconinc

* fix variant name for bzip2

* zstd is supported in libzip@:1.8

* fix style

* fix style

* fix style

* rm deprecated version and versions that cannot be found easily

use only cmake from now on

* fix style

* fix style

* use variant when option for zstd

* Update var/spack/repos/builtin/packages/libzip/package.py

Co-authored-by: Wouter Deconinck <[email protected]>

* fix style

/cc @wdconinc

---------

Co-authored-by: Wouter Deconinck <[email protected]>
teaguesterling pushed a commit to teaguesterling/spack that referenced this issue Feb 5, 2025
@prudhomm @wdconinc @teaguesterling
libzip: links with external libs found on host and new version (spack…
3f0eb09 
…#47230)

* libzip links with external libs found on host feelpp#6

* add maintainers

* fix style

* use multi-build system

/cc @wdconinc

* fix style

* rm space and rename variant bz2 to bzip2

/cc @wdconinc

* fix variant name for bzip2

* zstd is supported in libzip@:1.8

* fix style

* fix style

* fix style

* rm deprecated version and versions that cannot be found easily

use only cmake from now on

* fix style

* fix style

* use variant when option for zstd

* Update var/spack/repos/builtin/packages/libzip/package.py

Co-authored-by: Wouter Deconinck <[email protected]>

* fix style

/cc @wdconinc

---------

Co-authored-by: Wouter Deconinck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudhomm prudhomm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@prudhomm