mmg : add variant to install private headers for parmmg packaged #47386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer a more explicit variant name, e.g. The variant should be also appear as a dependency in the parmmg package : https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/parmmg/package.py |
|
Unless I am mistaken the option is only available for version 5.7.0 or later : MmgTools/mmg@9f98ef4 So the option should not be available for versions earlier than 5.7.0. |
tldahlgren
previously approved these changes
Nov 5, 2024
I have suggested a couple of minor changes. |
|
Ping me with a comment here when this is ready to merge. |
|
@tldahlgren @jcortial-safran I believe I applied the required changes. |
jcortial-safran
suggested changes
Dec 16, 2024
tldahlgren
reviewed
Dec 18, 2024
|
LGTM @tldahlgren |
jcortial-safran
approved these changes
Dec 18, 2024
tldahlgren
approved these changes
Dec 19, 2024
tdrwenski
pushed a commit
to tdrwenski/spack
that referenced
this pull request
Dec 26, 2024
…ck#47386) * update package : add variant to install private headers for parmmg package * re-add maintainer * renamed to +private_headers and only for 5.7: /cc @jcortial-safran * fix style and code * applied suggestions /cc @jcortial-safran @tldahlgren * fix
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Dec 26, 2024
…ck#47386) * update package : add variant to install private headers for parmmg package * re-add maintainer * renamed to +private_headers and only for 5.7: /cc @jcortial-safran * fix style and code * applied suggestions /cc @jcortial-safran @tldahlgren * fix
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Feb 5, 2025
…ck#47386) * update package : add variant to install private headers for parmmg package * re-add maintainer * renamed to +private_headers and only for 5.7: /cc @jcortial-safran * fix style and code * applied suggestions /cc @jcortial-safran @tldahlgren * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add private variant to install private headers thanks to MMG_INSTALL_PRIVATE_HEADERS needed by parmmg
/cc @jcortial-safran