Fix indicating waived failures when there is no scenario

On the Automated Tests tab, when a required test failed but the
failure has been waived, we intend to show a thumbs-up icon with
a tooltip with details about the waiver. However, if the failed
test has no 'scenario', this doesn't work, because there's a
hash key mismatch (we store the waiver under key "testcase##null"
but look it up under key "testcase##no_scenario").

This should fix that, and mean we correctly note waived failures
for Fedora CI results (openQA ones always have a scenario).

Signed-off-by: Adam Williamson <[email protected]>

Author: AdamWill

bodhi-server/bodhi/server/templates/update.html

@@ -957,7 +957,11 @@ <h3 class="modal-title" id="waiveModalLabel">Trigger Tests</h3>
                         if (!(requirement.subject_identifier in waived)) {
                             waived[requirement.subject_identifier] = {};
                         }
-                        var key = [requirement.testcase, requirement.scenario].join('##');
+                        var scenario = 'no_scenario';
+                        if (requirement.scenario) {
+                            scenario = requirement.scenario;
+                        }
+                        var key = [requirement.testcase, scenario].join('##');
                         waived[requirement.subject_identifier][key] = requirement.waiver_id;
                     }
                 });

news/PR5863.bug

@@ -0,0 +1 @@
+The Automated Tests tab now correctly indicates when a required test failure was waived if the test case has no 'scenario'.