New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated site: add pagination #34
Comments
@fahad19 Do we need to filter for pagination after getting the entire JSON or can we use a module like json-server(https://www.npmjs.com/package/json-server) for filtering? |
Thinking out loud, what would you prefer more:
the primary reason for opening this issue was because of rendering too much content in the same page in one go. if we have an easier way out with a "more" button, I am fine with that. what do you think, @jagadeeshgade008? if we add a "more" button at the bottom, may be we only show that button if the user is not searching for something specifically. meaning, the button only appears if the search input is empty |
Currently we are fetching entire json, |
Currently
Generate site currently lists all entities in one large list.
Problem
This can result into laggy experience in the browser.
Solution
We wish to add pagination for the list view for Features, Segments, and also Attributes.
History page does not have this issue, since it has a "Load more" button at the bottom.
Technical notes
More info: https://featurevisor.com/docs/site/
All components found here: https://github.com/fahad19/featurevisor/tree/main/packages/site/src/components
Local development tips
Make changes in
packages/site
, then do:See the changes in example app:
The text was updated successfully, but these errors were encountered: