Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting: show a soft warning if variables are overridden with default value #219

Open
fahad19 opened this issue Nov 24, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@fahad19
Copy link
Member

fahad19 commented Nov 24, 2023

Currently

Variables always fall back to their default value, and do not need overriding if that's the value you desire for e.g. at rule level.

Proposal

Throw a soft warning (without exiting with an error code) when running $ featurevisor lint if variables are overridden with their same default value, because it is redundant.

Where?

https://github.com/featurevisor/featurevisor/tree/main/packages/core/src/linter

@fahad19 fahad19 added the enhancement New feature or request label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant