Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SDK logs API key secret by default #20

Open
1 of 4 tasks
amandam11 opened this issue May 16, 2023 · 0 comments
Open
1 of 4 tasks

The SDK logs API key secret by default #20

amandam11 opened this issue May 16, 2023 · 0 comments

Comments

@amandam11
Copy link

Describe the bug
By default (unless the logger is overwritten) then the dotnet SDK logs the full URL it listens to which includes what should be treated as a secret - the API KEY.

For example:
INFO: Opening connection to $http://localhost:8064/features/default/<secret key>

Which area does this issue belong to?

  • SDK
  • SDK examples
  • Documentation
  • Other
  • [ ]

To Reproduce
Steps to reproduce the behavior:
1.Start client
2. See secret in the logs

Expected behavior
That secret information such as the api key is not logged by default.

Versions
FeatureHub version [1.6.0]
SDK version [using master branch]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant