Skip to content

Commit d1c5ac2

Browse files
MichaelDecisoAdSchellevis
authored andcommitted
Another round of corrections (opnsense#84)
1 parent 3756ed1 commit d1c5ac2

21 files changed

+55
-55
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ make html
4343

4444

4545
#### Changing theme
46-
* Install Sass (http://sass-lang.com/), on OSX via ```/Library/Ruby/Gems```
46+
* Install Sass (http://sass-lang.com/). On macOS, this is done via ```/Library/Ruby/Gems```
4747
```
4848
gem install --no-user-install sass
4949
```

source/development/components/acl.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,18 @@ determine if a page can be accessed by a user:
2121
user)
2222
#. One or more groups for that user, stored in system/group which
2323
contains priv sections.
24-
#. A php file binding the priv section content to a page mask (including
24+
#. A PHP file binding the priv section content to a page mask (including
2525
wildcards)
2626

2727
Our temporary solution is to keep the user and the group in place and replace the
28-
php file with a simple config in the model which uses the same mask construction
28+
PHP file with a simple config in the model which uses the same mask construction
2929
there was in the old codebase. To bind priv to pages, edit models/OPNsense/Core/ACL\_Legacy\_Page\_Map.txt
3030

3131
--------------
32-
Usage from php
32+
Usage from PHP
3333
--------------
3434

35-
Using the system from php is rather simple:
35+
Using the system from PHP is rather simple:
3636

3737
.. code-block:: php
3838

source/development/examples/helloworld.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ automatically understands the second file.
116116
117117
(/usr/local/opnsense/mvc/app/models/OPNsense/HelloWorld/HelloWorld.php)
118118

119-
Not all modules contain additional code in the php class, sometimes all
119+
Not all modules contain additional code in the PHP class, sometimes all
120120
the standard behaviour is already sufficient for your
121121
modules/application.
122122

@@ -176,7 +176,7 @@ Every OPNsense module should separate presentation from logic, that’s
176176
why there should always be multiple controllers per module.
177177

178178
Our first controller handles the template rendering to the user and
179-
connects the user view we just created. We start by creating a php file
179+
connects the user view we just created. We start by creating a PHP file
180180
in controllers/OPNsense/HelloWorld/ with the following name
181181
IndexController.php and contents:
182182

@@ -630,8 +630,8 @@ code:
630630
(/usr/local/opnsense/mvc/app/controllers/OPNsense/HelloWorld/Api/ServiceController.php)
631631

632632
This validates the type of action (it should always be POST to enable
633-
csrf protection) and adds a backend action for reloading the template.
634-
When successful the action will return status”:”ok” as json object back
633+
CSRF protection) and adds a backend action for reloading the template.
634+
When successful the action will return "status":"ok" as json object back
635635
to the client.
636636

637637
Now we are able to refresh the template content, but the user interface
@@ -675,9 +675,9 @@ next step.
675675
Controlling the sample
676676
----------------------
677677

678-
In stead of running all kinds of shell commands directly from the php
678+
Instead of running all kinds of shell commands directly from the PHP
679679
code, which very often need root access (starting/stopping services,
680-
etc), we should always communicate to our backend process which holds
680+
etc.), we should always communicate to our backend process which holds
681681
templates of possible things to run and protects your system from
682682
executing arbitrary commands.
683683

@@ -785,7 +785,7 @@ This works because we are using the gettext library which is available to all GU
785785
While the XML based user interfaces are supporting it automatically,
786786
there may still the need to call it manually (buttons, tabs etc.).
787787

788-
If you have a static string, you should add it like this into a classic php page:
788+
If you have a static string, you should add it like this into a classic PHP page:
789789

790790
.. code-block:: php
791791

source/development/frontend/controller.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ General
99
After routing is performed, the controller takes care of the actual code
1010
to execute for the request. Because we want to implement some basics for
1111
every request that gets processed you should inherit from our base
12-
classes to ensure basic functionality such as authorisation and csrf
12+
classes to ensure basic functionality such as authorisation and CSRF
1313
protection.
1414

1515
Controllers are placed in the directory /usr/local/opnsense/mvc/app/controllers/<Vendor\_name>/<Module\_name>/
@@ -63,7 +63,7 @@ API based controllers
6363
For API calls a separate class is used to derive from, which implements
6464
a simple interface to handle calls. The main difference with the view
6565
controllers is that an action should return a named array containing
66-
response data in stead of picking a template.
66+
response data instead of picking a template.
6767

6868
A simple index controller to echo a request back looks like this:
6969

@@ -87,7 +87,7 @@ A simple index controller to echo a request back looks like this:
8787
}
8888
8989
When placed inside the API directory of Vendor/Sample can be called by sending a
90-
post request to /api/sample/test/echo, using jquery:
90+
post request to /api/sample/test/echo, using jQuery:
9191

9292
.. code-block:: javascript
9393

source/development/frontend/models.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Designing the model
1616

1717
Creating models for OPNsense is divided into two separate blocks:
1818

19-
#. A php class describing the actions on our data (also acts as a
19+
#. A PHP class describing the actions on our data (also acts as a
2020
wrapper to our data),
2121
#. The definition of the data and the rules it should apply to.
2222

@@ -130,7 +130,7 @@ their own namespace at *OPNsense\\Base\\FieldTypes* deriving from *BaseField*.
130130
Usage example
131131
-------------
132132

133-
Now let's test our model using a small php script (in /usr/local/opnsense/mvc/script/ ):
133+
Now let's test our model using a small PHP script (in /usr/local/opnsense/mvc/script/ ):
134134

135135
.. code-block:: php
136136

source/development/frontend/routing.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ API routing
6565
Routing for API functions is quite similar to routing UI components,
6666
just create a Api directory under the app path and place a controller
6767
class to handle the request. The only major difference is that it's
68-
handled by a separate php file (called api.php) in stead of the
68+
handled by a separate PHP file (called api.php) instead of the
6969
index.php file used to configure the ui part, details of the routing can
7070
be found in /usr/local/opnsense/mvc/app/config/services\_api.php .
7171

source/manual/how-tos/bind.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ General Settings
4242

4343

4444
:DNS Forwarders:
45-
A list of IP addresses BIND will forward unknown dns request to. If empty BIND
45+
A list of IP addresses BIND will forward unknown DNS request to. If empty BIND
4646
tries to resolve directly via the root servers.
4747
:Logsize in MB:
4848
The amount for each logfile it can grow.

source/manual/how-tos/carp.rst

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ we will explain briefly first:
3838

3939
Common Address Redundancy Protocol uses IP protocol 112, is derived from
4040
OpenBSD and uses multicast packets to signal its neighbours about its
41-
status. Always make sure that each interface can receive carp packets.
41+
status. Always make sure that each interface can receive CARP packets.
4242
Every virtual interface must have a unique Virtual Host ID (vhid), which
4343
is shared across the physical machines. To determine which physical
4444
machine has a higher priority, the advertised skew is used. A lower skew
@@ -59,7 +59,7 @@ security reasons (state injection) as for performance.
5959
:name: xmlrpc-sync
6060

6161
OPNsense includes a mechanism to keep the configuration of the backup
62-
server in sync with the master. This mechanism is called xmlrpc sync and
62+
server in sync with the master. This mechanism is called XMLRPC sync and
6363
can be found under System -> High Availability.
6464

6565
-----------------------------------------
@@ -91,7 +91,7 @@ setup the following addresses and subnets:
9191

9292
Next we need to make sure the appropriate protocols can be used on the
9393
different interfaces, go to firewall -> rules and make sure both LAN and
94-
WAN accept at least carp packets (see protocol selection). Because we're
94+
WAN accept at least CARP packets (see protocol selection). Because we're
9595
connecting both firewalls using a direct cable connection, we will add a
9696
single rule to accept all traffic on all protocols for that specific
9797
interface. Another option is to only accept traffic to the GUI port and
@@ -111,7 +111,7 @@ The backup server needs its own dedicated addresses, we will use these:
111111
+----------+-------------------+
112112

113113
Because we are going to synchronize firewall settings between both
114-
hosts, we only need to make sure that the pfsync interface can accept
114+
hosts, we only need to make sure that the pfSync interface can accept
115115
data from the master for the initial setup. Use the same rule as used
116116
for the master on this interface.
117117

@@ -175,12 +175,12 @@ nat on this page and change the rules originating from the
175175
(optional) Setup DHCP server
176176
----------------------------
177177

178-
When using dhcp for the local area network, there are some things to
179-
consider. All clients should use the virtual address in stead of the
178+
When using DHCP for the local area network, there are some things to
179+
consider. All clients should use the virtual address instead of the
180180
physical address it's normally propagating. Next thing to consider is
181181
there will be two servers active at the same time, which should know of
182-
each others pools. If dns requests are also forwarded by OPNsense, make
183-
sure the dhcp server sends the right IP address. These are settings used
182+
each others pools. If DNS requests are also forwarded by OPNsense, make
183+
sure the DHCP server sends the right IP address. These are settings used
184184
in our example (on the master server):
185185

186186
+--------------------+----------------+
@@ -196,7 +196,7 @@ Setup HA sync (xmlrpc) and pfSync
196196
---------------------------------
197197

198198
First we should enable pfSync using our dedicated interface using the
199-
master firewall. Go to System -> High Availability, enable pfsync and
199+
master firewall. Go to System -> High Availability, enable pfSync and
200200
select the interface used for pfSync. Next setup the peer IP to the
201201
other hosts address (10.0.0.2).
202202

source/manual/how-tos/ipsec-road.rst

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
Setup IPsec Road-Warrior
33
========================
44
Road Warriors are remote users who need secure access to the companies infrastructure.
5-
IPsec Mobile Clients offer a solution that is easy to setup with OSX (native)
5+
IPsec Mobile Clients offer a solution that is easy to setup with macOS (native)
66
and is know to work with iOS as well as many Android devices.
77

8-
For more flexibility use SSL VPN's, OPNsense utilizes OpenVPN for this purpose.
8+
For more flexibility use SSL VPNs, OPNsense utilizes OpenVPN for this purpose.
99

1010
With this example we'll show you how to configure the Mobile Client Setup in
1111
OPNsense and give you configuration examples for:
1212

13-
* OSX
13+
* macOS
1414
* iOS
1515
* Android
1616

@@ -272,16 +272,16 @@ Add privilege **User - VPN - IPsec xauth Dialin** by pressing the **+** under
272272
-------------------------
273273
Step 5 - Configure Client
274274
-------------------------
275-
To illustrate the client setup we will look at the configuration under OSX, including
275+
To illustrate the client setup we will look at the configuration under macOS, including
276276
some screenshots. The configurations for Android and iOS will be settings only.
277277

278278
.. Note::
279-
Configuration samples listed here where created using latest OSX, iOS and
279+
Configuration samples listed here where created using latest macOS, iOS and
280280
Android devices on time of publication in February 2016.
281281

282-
--------------------
283-
Configure OSX Client
284-
--------------------
282+
----------------------
283+
Configure macOS Client
284+
----------------------
285285

286286
Start with opening your network settings (System Preferences -> Network) and
287287
Add a new network by pressing the + in the lower left corner.

source/manual/how-tos/ipsec-s2s.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Setup IPsec site to site tunnel
33
================================
44

5-
Site to site VPN's connect two locations with static public IP addresses and allow
5+
Site to site VPNs connect two locations with static public IP addresses and allow
66
traffic to be routed between the two networks. This is most commonly used to
77
connect an organization's branch offices back to its main office, so branch users
88
can access network resources in the main office.
@@ -513,7 +513,7 @@ Phase 1 works but no phase 2 tunnels are connected
513513
---------------------------------------------------
514514

515515
Did you set the correct local and remote networks. A common mistake is to fill in
516-
the IP address of the remote host in stead of its network ending with **x.x.x.0**
516+
the IP address of the remote host instead of its network ending with **x.x.x.0**
517517

518518
Common issues are unequal settings. Both ends must use the same encryption standard.
519519

0 commit comments

Comments
 (0)