feat: Add URL validation contract and error messages #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fazedordecodigo
requested changes
Oct 11, 2024
|
Please check the existing conflict as well. |
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (4)
tests/validations/test_url_validation_contract.py:18
- The test case for 'None' value is not necessary as 'None' is not a valid string input for URL validation. Consider removing this test case.
(None, False),
tests/validations/test_url_validation_contract.py:36
- The test case for 'None' value is not necessary as 'None' is not a valid string input for URL validation. Consider removing this test case.
(None, True),
tests/validations/test_url_validation_contract.py:54
- The test case for 'None' value is not necessary as 'None' is not a valid string input for URL validation. Consider removing this test case.
(None, True),
tests/validations/test_url_validation_contract.py:72
- The test case for 'None' value is not necessary as 'None' is not a valid string input for URL validation. Consider removing this test case.
(None, True),
| @@ -1,5 +1,10 @@ | |||
| from flunt.constants import MAX_LENGTH, REQUIRED | |||
|
|
|||
| IS_URL_ERROR_MESSAGE = lambda key: f"{key} is not a valid URL." | |||
| IS_URL_OR_EMPTY_ERROR_MESSAGE = lambda key: f"{key} is not a valid URL or empty." | |||
| IS_NOT_URL_ERROR_MESSAGE = lambda key: f"{key} is a valid URL." | |||
There was a problem hiding this comment.
The error message 'key is a valid URL' is unclear. It should be changed to 'key should not be a valid URL.'
Suggested change
| IS_NOT_URL_ERROR_MESSAGE = lambda key: f"{key} is a valid URL." | |
| IS_NOT_URL_ERROR_MESSAGE = lambda key: f"{key} should not be a valid URL." |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed Changes
Fixed issue #33 by adding the necessary error messages, classes, and methods to add the UrlValidationContract.
Review Checklist
Additional Comments (optional)
Related Issue
#33
Closes #33