Allow safe navigation operator

Author: fatkodima

.rubocop.yml

@@ -54,7 +54,7 @@ Style/ConditionalAssignment:
   Enabled: false
 
 Style/SafeNavigation:
-  Enabled: false
+  MaxChainLength: 1
 
 Style/NumericLiterals:
   Enabled: false
@@ -93,7 +93,6 @@ Style/ArgumentsForwarding:
 Style/DisableSyntax:
   DisableSyntax:
     - unless
-    - safe_navigation
     - endless_methods
     - arguments_forwarding
     - numbered_parameters

lib/generators/online_migrations/upgrade_generator.rb

@@ -48,7 +48,7 @@ def migrations_to_apply
         end
 
         iteration_pause_column = connection.columns(:background_data_migrations).find { |c| c.name == "iteration_pause" }
-        if iteration_pause_column && iteration_pause_column.default
+        if iteration_pause_column&.default
           migrations << "background_data_migrations_remove_iteration_pause_default"
         end
 

lib/online_migrations/command_checker.rb

@@ -843,8 +843,8 @@ def index_corruption?
 
       def index_include_column?(index, column)
         index.columns.include?(column) ||
-          (index.include && index.include.include?(column)) ||
-          (index.where && index.where.include?(column))
+          index.include&.include?(column) ||
+          index.where&.include?(column)
       end
 
       def run_custom_checks(method, args)

lib/online_migrations/schema_statements.rb

@@ -111,7 +111,7 @@ def update_columns_in_batches(table_name, columns_and_values,
 
         relation.update_all(updates)
 
-        progress.call(relation) if progress
+        progress.call(relation) if progress.present?
 
         sleep(pause_ms * 0.001) if pause_ms > 0
       end

lib/online_migrations/utils.rb

@@ -145,7 +145,7 @@ def multiple_databases?
 
       def run_background_migrations_inline?
         run_inline = OnlineMigrations.config.run_background_migrations_inline
-        run_inline && run_inline.call
+        run_inline.call if run_inline.present?
       end
     end
   end