Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a decorator instead of base class for NumbaEroders #160

Open
adriendelsalle opened this issue Jun 12, 2024 · 0 comments
Open

Use a decorator instead of base class for NumbaEroders #160

adriendelsalle opened this issue Jun 12, 2024 · 0 comments

Comments

@adriendelsalle
Copy link
Contributor 

          I think I would prefer a class decorator over a base class here. A decorator would be:
  • similar to Numba's jitclass decorator
  • a bit better for documenting the required members spec, outputs and application_order
  • also similar to how we use the fastscape high-level API (via xarray-simlab "process" decorated classes)

This can be addressed in a follow-up PR, though.

Originally posted by @benbovy in #157 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adriendelsalle