Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request For October 2021 Apple Devices #25

Open
dweekly opened this issue Oct 7, 2021 · 4 comments
Open

Request For October 2021 Apple Devices #25

dweekly opened this issue Oct 7, 2021 · 4 comments

Comments

@dweekly
Copy link

dweekly commented Oct 7, 2021

Hey folks! Thanks for an awesome product.

I realize these new devices are just making their way out into the field, so I'm sure someone's already on it, but I didn't see a formal Issue request logged for this yet, so here it is:

  • iPhone 13 (Pink, Blue, Midnight, Starlight, Red)
  • iPhone 13 Pro (Sierra Blue, Silver, Gold, Graphite)
  • iPhone 13 Pro Max (Sierra Blue, Silver, Gold, Graphite)
  • iPad Mini (2021) (Space Gray, Pink, Purple, Starlight)
  • iPad (2021) (Space Gray, Silver)
@dweekly
Copy link
Author

dweekly commented Oct 20, 2021

Ah, it looks like these devices are not yet available from https://facebook.design/devices which is the origin of these.

@sathoeni
Copy link
Contributor

sathoeni commented Nov 9, 2021

The iPhone 13 device frames are now available.
I've added them in Pull Request #27

@dweekly
Copy link
Author

dweekly commented Nov 9, 2021

Superb! Thank you! Looks like we will have to wait separately for Facebook (err, Meta) to update iPad Mini 2021 and iPad 2021.

@mgrider
Copy link

mgrider commented Apr 11, 2022

This issue seems... closable.

I think maybe this should be a separate issue, but my guess is that the iPhone SE (3rd Generation) is too new to be included in this repo. My evidence is that it's not working for me to run fastlane run frameit in a folder containing a screenshot of that simulator. I get the following message:

[17:25:20]: Unsupported screen size [1125, 2001] for path './testPage2.iPhoneSE3rdGen.png'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants