Merge pull request #246 from fastlabel/bugfix/9301_encode-object-name-parameter

#9301 find_dataset_object, delete_dataset_objectに渡すobject_nameに/が含まれていると404エラーになる

Author: ryoKaz

examples/delete_dataset_object.py

@@ -3,5 +3,5 @@
 client = fastlabel.Client()
 
 client.delete_dataset_object(
-    dataset_id="YOUR_DATASET_OBJECT_ID", object_name="YOUR_OBJECT_NAME"
+    dataset_id="YOUR_DATASET_ID", object_name="YOUR_OBJECT_NAME"
 )

examples/find_dataset_object.py

@@ -5,6 +5,6 @@
 client = fastlabel.Client()
 
 dataset_object = client.find_dataset_object(
-    dataset_id="YOUR_DATASET_OBJECT_ID", object_name="YOUR_OBJECT_NAME"
+    dataset_id="YOUR_DATASET_ID", object_name="YOUR_OBJECT_NAME"
 )
 pprint(dataset_object)

fastlabel/__init__.py

@@ -3,6 +3,7 @@
 import logging
 import os
 import re
+import urllib.parse
 from concurrent.futures import ThreadPoolExecutor, wait
 from pathlib import Path
 from typing import Dict, List, Literal, Optional, Union
@@ -4251,7 +4252,10 @@ def find_dataset_object(
             raise FastLabelInvalidException(
                 "only use specify one of revisionId or version.", 400
             )
-        endpoint = "datasets-v2/" + dataset_id + "/objects/" + object_name
+        encoded_object_name = urllib.parse.quote(object_name, safe="")
+        endpoint = (
+            "dataset-objects-v2/" + dataset_id + "/objects/" + encoded_object_name
+        )
         params = {}
         if revision_id:
             params["revisionId"] = revision_id
@@ -4474,7 +4478,10 @@ def delete_dataset_object(self, dataset_id: str, object_name: str) -> None:
         """
         Delete a dataset object.
         """
-        endpoint = "datasets-v2/" + dataset_id + "/objects/" + object_name
+        encoded_object_name = urllib.parse.quote(object_name, safe="")
+        endpoint = (
+            "dataset-objects-v2/" + dataset_id + "/objects/" + encoded_object_name
+        )
         self.api.delete_request(endpoint)
 
     def update_aws_s3_storage(