New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define batching impl #63

Open

ManiMozaffar opened this issue Aug 19, 2023 · 0 comments

Labels

Member

ManiMozaffar commented Aug 19, 2023

Decouple batching and performing the request, by using a new class called Batcher

def get_batches(self)-> iterable[Batch]:
    return list(Batch(engine=self.engine, setting=self.setting, ...))


for batch in self.get_barches(): 
     batch_results = await Batch.perform()
     parsed_result = Parse(batch_result)

ManiMozaffar added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment