Skip to content

Commit cc0a829

Browse files
authored
Update to Node 22 (#129)
1 parent e70a3fa commit cc0a829

File tree

8 files changed

+32
-39
lines changed

8 files changed

+32
-39
lines changed

.github/workflows/ci.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Set up Node
2323
uses: actions/setup-node@v4
2424
with:
25-
node-version: 20.x
25+
node-version: 22.x
2626

2727
- name: Install
2828
working-directory: airbyte-local-cli-nodejs
@@ -81,7 +81,7 @@ jobs:
8181
- name: Set up Node
8282
uses: actions/setup-node@v4
8383
with:
84-
node-version: 20.x
84+
node-version: 22.x
8585

8686
- name: Install and Build
8787
working-directory: airbyte-local-cli-nodejs
@@ -179,7 +179,7 @@ jobs:
179179
- name: Set up Node
180180
uses: actions/setup-node@v2
181181
with:
182-
node-version: 20.x
182+
node-version: 22.x
183183

184184
- name: Install
185185
working-directory: airbyte-local-cli-nodejs

airbyte-local-cli-nodejs/.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20.18
1+
22

airbyte-local-cli-nodejs/DEVELOPER.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# WIP: Airbyte CLI Rewrite
22

33
```sh
4-
nvm use # Use Node v20
4+
nvm use # Use Node v22
55
npm run build # Build src
66
npm run lint # Check formatting
77
npm run bundle # Bundle typescripts source codes to a single Javascript file

airbyte-local-cli-nodejs/package-lock.json

Lines changed: 20 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

airbyte-local-cli-nodejs/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@faros-ai/airbyte-local-cli-nodejs",
3-
"version": "0.0.2",
3+
"version": "0.0.3",
44
"description": "Airbyte local cli node js version",
55
"private": true,
66
"packageManager": "^[email protected]",
@@ -28,16 +28,16 @@
2828
"url": "https://github.com/faros-ai/airbyte-local-cli/issues"
2929
},
3030
"engines": {
31-
"node": ">=20.0.0"
31+
"node": ">=22.0.0"
3232
},
3333
"main": "lib/",
3434
"devDependencies": {
35-
"@tsconfig/node20": "^20.1.4",
35+
"@tsconfig/node22": "^22.0.1",
3636
"@tsconfig/strictest": "^2.0.5",
37-
"@types/dockerode": "^3.3.32",
37+
"@types/dockerode": "^3.3.37",
3838
"@types/jest": "^29.5.14",
3939
"@types/lodash": "^4.17.14",
40-
"@types/node": "^20.17.6",
40+
"@types/node": "^22.14.0",
4141
"@typescript-eslint/eslint-plugin": "^8.19.1",
4242
"@typescript-eslint/parser": "^8.13.0",
4343
"@yao-pkg/pkg": "^6.3.2",

airbyte-local-cli-nodejs/src/docker.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -295,13 +295,6 @@ export async function runSrcSync(tmpDir: string, config: FarosConfig, srcOutputS
295295
? createWriteStream(config.srcOutputFile)
296296
: process.stdout);
297297

298-
// Close the output stream when the container is finished
299-
if (srcOutputStream) {
300-
outputStream.on('finish', () => {
301-
srcOutputStream.end();
302-
});
303-
}
304-
305298
// create a writable stream to capture the stdout
306299
let buffer = '';
307300
const containerOutputStream = new Writable({
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export const CLI_VERSION = '0.0.2';
1+
export const CLI_VERSION = '0.0.3';

airbyte-local-cli-nodejs/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": ["@tsconfig/node20/tsconfig", "@tsconfig/strictest/tsconfig"],
2+
"extends": ["@tsconfig/node22/tsconfig", "@tsconfig/strictest/tsconfig"],
33
"compilerOptions": {
44
"module": "commonjs",
55
"moduleResolution": "node",

0 commit comments

Comments
 (0)