Fix SAML user does not exist logging call #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by how we did not use Python's old string formatting operator to inject the problematic id into the log message. This issue caused one of our SAML logging calls to raise its own error last week and consequently the "user not found error" percolated up to a user instead of redirecting them to a denied page. For the sake of clarity, we will now manually format the string injected into the logger (as opposed to allowing the logging module to only generate the final msg if the log would actually be produced) as this is a fairly inexpensive operation.
See logs here