Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_client parameter missing for datasets.open? #151

Open
sbalian opened this issue Dec 28, 2019 · 1 comment
Open

object_client parameter missing for datasets.open? #151

sbalian opened this issue Dec 28, 2019 · 1 comment

Comments

@sbalian
Copy link
Contributor

sbalian commented Dec 28, 2019

def open(project_path, mode="r", temp_dir=None, project_id=None, **kwargs):

Is there a reason this does not have a object_client parameter like the others? How else do you recommend using this outside of the Platform?

@acroz
Copy link
Member

acroz commented Jan 6, 2020

Is there a reason this does not have a object_client parameter like the others?

Not particularly, no. open is a convenience function built on the others and I think we just didn't anticipate people using it in the advanced case described below.

How else do you recommend using this outside of the Platform?

The main reason for the object_client parameter is so that these methods can pass around a single client and avoid reconstructing it many times. People are mainly expected to use the profile mechanism and environment variables as the way to configure which deployment to interact with datasets, though this is mostly for historical reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants