-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide js assets in the source tarball #334
Comments
I'm fine with this idea but I'll to take a look at it to see how I can automate this as the current source tarballs available are automatically generated by Github. |
Yeah, and our build infra is able to fetch a tarball from the github tag, but that doesnt have the assets - i fully understand if you dont want to commit the assets to the repository, so maybe it's only a matter of providing a 'tarball' target in the Makefile that builds the assets and creates the source tarball. - after that, either the distributors use this target to create and host the tarball themselves, or upstream provides it, but that's more work for you :/ |
It's ok for me having such I'll try to add this on the master branch soon. |
just discussed this with @falzm, for 'distro' packagers itwould be super nice to provide js assets in the source tarball we grab from github so that we dont have npm/bower reaching out to internet during build - otherwise we need to repackage ourself the source tarball, manually adding the assets that were locally fetched.
The text was updated successfully, but these errors were encountered: