relay-compiler validate fails for locally persisted queries

[michalsanger]

After upgrade to current compiler version 20.1.0 the validation fails with:

[INFO] Querying files to compile...
[INFO] [default] compiling...
[INFO] [default] compiled documents: 323 reader, 135 normalization, 376 operation text
[ERROR] Artifacts validation failed: 
// list of all __generated__/*.graphql.ts files
[ERROR] Compilation failed.
[ERROR] Unable to run relay compiler. Error details: 
Artifacts validation failed: 
Out of date:
// list of all __generated__/*.graphql.ts files

In relay.config.js I have:

persistConfig: {
    file: './relay/persistedQueries.json',
    algorithm: 'MD5',
},

I see #5013 in the changelog and I guess it makes sense to disable validation for RemotePersistConfig but not for LocalPersistConfig.

[captbaritone]

Thanks for the report. I'm able to repro. More generally I'm a little confused as to how #5013 is supposed to work at all. Without the persister we generate different artifacts (critically we omit the "id" field in the query artifact and, depending upon the configuration may omit the query text). I don't see how we can ever have --validate work with persist disabled if the project was build with persist enabled.

Probably we should revert #5013.

What do you think @aryaniyaps? Am I missing something?

[captbaritone]

Repro repo: https://github.com/captbaritone/relay-validate-bug-repro

[aryaniyaps]

Yes @captbaritone I think that it must be reverted. I assumed that we could disable the network requests made by removing the persister like that. I didn't know that it would also remove ID generation, Im sorry!