-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] es modules, no global polution #302
Comments
Please feel free to submit a PR for this! |
Any update on this? With regenerator-runtime auto pollutes the global-scope, there's no way to achieve a 100% pure polyfilling without scope pollution as described in babel/babel-polyfills#59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
this would mean breaking change
So basically what I would like to do (I can prepare PRs) is to refactor packages. Changes should be pretty straightforward and would include:
regenerator-runtime
, both commonjs and esregenerator-transform
to add an import forregenerator-runtime
to the transformed module if needed - we can support old way (using global) with an option to the transformBenefits:
regenerator-runtime
- when one uses i.e. only normal generators then parts about async functions could be tree-shaken easilyI think the module is stable and this would make for a great v1 release.
The text was updated successfully, but these errors were encountered: