Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for re-mounting layout effects when re-suspending #26893

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rickhanlonii
Copy link
Member

I couldn't find a test for this anywhere, feel free to close if we do have one that covers this.

@rickhanlonii rickhanlonii requested a review from acdlite June 2, 2023 12:41
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 2, 2023
@rickhanlonii
Copy link
Member Author

rickhanlonii commented Jun 2, 2023

We have a test for Offscreen for this, but not one that uses Suspense (I think). So I just copied this and replaced using Offscreen directly with using Suspense.

it('mounts/unmounts layout effects when visibility changes (starting visible)', async () => {

@react-sizebot
Copy link

Comparing: 0210f0b...b714f5e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.23 kB 164.23 kB = 51.77 kB 51.77 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.59 kB 171.59 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js = 570.42 kB 570.42 kB = 100.64 kB 100.64 kB
facebook-www/ReactDOM-prod.modern.js = 554.16 kB 554.16 kB = 97.82 kB 97.82 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against b714f5e

@rickhanlonii rickhanlonii marked this pull request as draft March 22, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants