Bug: The ESLint react-hooks/immutability rule warns against using a callback internally

[4eb0da]

eslint-plugin-react-hooks version: 7.0.1

Steps To Reproduce

const Test: FC = () => {
    const onMouseDown = useCallback(() => {
        // warns here about using onMouseDown
        window.removeEventListener('mousedown', onMouseDown);
    }, []);

    useEffect(() => {
        window.addEventListener('mousedown', onMouseDown);

        return () => {
            window.removeEventListener('mousedown', onMouseDown);
        };
    }, [onMouseDown]);

    return <div>Hello</div>;
};

The current behavior

`onMouseDown` is accessed before it is declared, which prevents the earlier access from updating when this value changes over time.

The expected behavior

No errors

[codewithzubair07]

I’d like to take a look at this and work on a fix if that’s okay.

From what I can see, this appears to be a false positive caused by the react-hooks/immutability rule not handling self-references inside stable callbacks (useCallback with empty deps). At runtime the function is fully initialized before invocation, so there’s no real immutability or stale-closure issue here.

My plan would be to:

Add a minimal rule-level test reproducing this case

Investigate where the rule treats self-references as “access before declaration”

Adjust the analysis to allow self-references when the callback identity is stable

Please let me know if this approach sounds reasonable or if there’s a preferred direction for handling this in the rule.