Add `fetchPriority` to `<img>` and `<link>` #25927

styfle · 2022-12-22T21:22:21Z

Summary

How did you test this change?

I tried this but it didn't work

yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn start

eps1lon

I tried this but it didn't work

Thank you for reporting! I filed #25928 and will update the fixture with the correct values.

fixtures/attribute-behavior/src/attributes.js

1. always read correct property (to test compat with lowercase prop name) 1. use a known string value to test read/write parity Ran fixture with meta tags enabled in Chrome Version 107.0.5304.110 (Official Build) (64-bit) on Ubuntu 22.04

eps1lon · 2022-12-23T11:09:16Z

@styfle Could you check if the value in the attribute fixture match your expectation?

styfle · 2022-12-23T18:45:41Z

fixtures/attribute-behavior/src/attributes.js

@@ -573,6 +573,24 @@ const attributes = [
 tagName: 'path',
 read: getSVGAttribute('externalResourcesRequired'),
 },
+ {
+ name: 'fetchPriority',
+ overrideStringValue: 'high',


@eps1lon Why would this override? I'm not sure I understand the purpose of overrideStringValue 🤔

Just so that we test with a valid value instead of an arbitrary one that you'd never use in a real application

## Summary - Fixes #25682 ## How did you test this change? I tried this but it didn't work ``` yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn start ``` Co-authored-by: eps1lon <[email protected]> DiffTrain build for [de7d1c9](de7d1c9) [View git log for this commit](https://github.com/facebook/react/commits/de7d1c90718ea8f4844a2219991f7115ef2bd2c5)

Summary: This sync includes the following changes: - **[48b687fc9](facebook/react@48b687fc9 )**: [trusted types][www] Add enableTrustedTypesIntegration flag back in ([#26016](facebook/react#26016)) //<an onion>// - **[9b1423cc0](facebook/react@9b1423cc0 )**: Revert "Hold host functions in var" ([#26079](facebook/react#26079)) //<Samuel Susla>// - **[ce09ace9a](facebook/react@ce09ace9a )**: Improve Error Messages when Access Client References ([#26059](facebook/react#26059)) //<Sebastian Markbåge>// - **[0652bdbd1](facebook/react@0652bdbd1 )**: Add flow types to Maps in ReactNativeViewConfigRegistry.js ([#26064](facebook/react#26064)) //<Samuel Susla>// - **[ee8509801](facebook/react@ee8509801 )**: [cleanup] remove deletedTreeCleanUpLevel feature flag ([#25529](facebook/react#25529)) //<Jan Kassens>// - **[0e31dd028](facebook/react@0e31dd028 )**: Remove findDOMNode www shim ([#25998](facebook/react#25998)) //<Jan Kassens>// - **[379dd741e](facebook/react@379dd741e )**: [www] set enableTrustedTypesIntegration to false ([#25997](facebook/react#25997)) //<Jan Kassens>// - **[555ece0cd](facebook/react@555ece0cd )**: Don't warn about concurrently rendering contexts if we finished rendering ([#22797](facebook/react#22797)) //<Sebastian Silbermann>// - **[0fce6bb49](facebook/react@0fce6bb49 )**: [cleanup] remove feature flags warnAboutDefaultPropsOnFunctionComponents and warnAboutStringRefs ([#25980](facebook/react#25980)) //<Jan Kassens>// - **[7002a6743](facebook/react@7002a6743 )**: [cleanup] remove unused values from ReactFeatureFlags.www-dynamic ([#25575](facebook/react#25575)) //<Jan Kassens>// - **[a48e54f2b](facebook/react@a48e54f2b )**: [cleanup] remove old feature flag warnAboutDeprecatedLifecycles ([#25978](facebook/react#25978)) //<Jan Kassens>// - **[0f4a83596](facebook/react@0f4a83596 )**: Remove duplicate JSResourceReferenceImpl mock ([#25976](facebook/react#25976)) //<Jan Kassens>// - **[c49131669](facebook/react@c49131669 )**: Remove unused Flow suppressions ([#25977](facebook/react#25977)) //<Jan Kassens>// - **[afe6521](facebook/react@afe6521e1 )**: Refactor: remove useless parameter ([#25923](facebook/react#25923)) //<Chris>// - **[34464fb16](facebook/react@34464fb16 )**: Upgrade to Flow 0.196.3 ([#25974](facebook/react#25974)) //<Jan Kassens>// - **[e2424f33b](facebook/react@e2424f33b )**: [flow] enable exact_empty_objects ([#25973](facebook/react#25973)) //<Jan Kassens>// - **[0b4f44302](facebook/react@0b4f44302 )**: [flow] enable enforce_local_inference_annotations ([#25921](facebook/react#25921)) //<Jan Kassens>// - **[0b974418c](facebook/react@0b974418c )**: [Fizz] Fork Fizz instruction set for inline script and external runtime ([#25862](facebook/react#25862)) //<mofeiZ>// - **[5379b6123](facebook/react@5379b6123 )**: Batch sync, default and continuous lanes ([#25700](facebook/react#25700)) //<Tianyu Yao>// - **[bbf4d2211](facebook/react@bbf4d2211 )**: Update import for babel-code-frame in build script ([#25963](facebook/react#25963)) //<Ming Ye>// - **[b83baf63f](facebook/react@b83baf63f )**: Transform updates to support Flow this annotation syntax ([#25918](facebook/react#25918)) //<Jan Kassens>// - **[c2d655207](facebook/react@c2d655207 )**: Unify `use` and `renderDidSuspendDelayIfPossible` implementations ([#25922](facebook/react#25922)) //<Andrew Clark>// - **[48274a43a](facebook/react@48274a43a )**: Remove vestigial Suspense batching logic ([#25861](facebook/react#25861)) //<Andrew Clark>// - **[de7d1c907](facebook/react@de7d1c907 )**: Add `fetchPriority` to `<img>` and `<link>` ([#25927](facebook/react#25927)) //<Steven>// - **[81d4ee9ca](facebook/react@81d4ee9ca )**: reconciler docs: fix small typo - "mode" (instead of "node") ([#25863](facebook/react#25863)) //<satelllte>// - **[5fcf1a4b4](facebook/react@5fcf1a4b4 )**: Bugfix: Synchronous ping during render phase sometimes unwinds the stack, leading to crash ([#25851](facebook/react#25851)) //<Andrew Clark>// - **[2b1fb91a5](facebook/react@2b1fb91a5 )**: ESLint upgrade to use hermes-eslint ([#25915](facebook/react#25915)) //<Jan Kassens>// - **[fabef7a6b](facebook/react@fabef7a6b )**: Resubmit Add HydrationSyncLane ([#25878](facebook/react#25878)) //<Tianyu Yao>// - **[7efa9e597](facebook/react@7efa9e597 )**: Fix unwinding context during selective hydration ([#25876](facebook/react#25876)) //<Tianyu Yao>// - **[84a0a171e](facebook/react@84a0a171e )**: Rename experimental useEvent to useEffectEvent ([#25881](facebook/react#25881)) //<Sebastian Markbåge>// - **[4dda96a40](facebook/react@4dda96a40 )**: [react-www] remove forked bundle ([#25866](facebook/react#25866)) //<Jan Kassens>// - **[9c09c1cd6](facebook/react@9c09c1cd6 )**: Revert "Fork ReactDOMSharedInternals for www ([#25791](facebook/react#25791))" ([#25864](facebook/react#25864)) //<lauren>// - **[996e4c0d5](facebook/react@996e4c0d5 )**: Offscreen add attach ([#25603](facebook/react#25603)) //<Samuel Susla>// - **[b14d7fa4b](facebook/react@b14d7fa4b )**: Add support for setNativeProps to Fabric ([#25737](facebook/react#25737)) //<Samuel Susla>// - **[819687279](facebook/react@819687279 )**: [Float] Fix typo in ReactDOMResourceValidation.js ([#25798](facebook/react#25798)) //<Ikko Ashimine>// - **[5dfc485f6](facebook/react@5dfc485f6 )**: fix tests for when float is off ([#25839](facebook/react#25839)) //<Josh Story>// - **[bfcbf3306](facebook/react@bfcbf3306 )**: toString children of title ([#25838](facebook/react#25838)) //<Sebastian Markbåge>// - **[d4bc16a7d](facebook/react@d4bc16a7d )**: Revert "[react-www] remove forked bundle" ([#25837](facebook/react#25837)) //<Ricky>// - **[d69b2cf82](facebook/react@d69b2cf82 )**: [bug fix] revert values in ReactFiberFlags to keep consistency for devtools ([#25832](facebook/react#25832)) //<Mengdi Chen>// - **[645ae2686](facebook/react@645ae2686 )**: [react-www] remove forked bundle ([#25831](facebook/react#25831)) //<Jan Kassens>// - **[d807eb52c](facebook/react@d807eb52c )**: Revert recent hydration changes ([#25812](facebook/react#25812)) //<Andrew Clark>// - **[2ccfa657d](facebook/react@2ccfa657d )**: Fork ReactDOMSharedInternals for www ([#25791](facebook/react#25791)) //<lauren>// - **[f0534ae94](facebook/react@f0534ae94 )**: Avoid replaying SelectiveHydrationException in dev ([#25754](facebook/react#25754)) //<Tianyu Yao>// - **[7fab379d8](facebook/react@7fab379d8 )**: fix link to ReactDOMHostconfig in reconciler docs ([#25788](facebook/react#25788)) //<Dmitry>// - **[500c8aa08](facebook/react@500c8aa08 )**: Add component name to StrictMode error message ([#25718](facebook/react#25718)) //<Samuel Susla>// - **[353c30252](facebook/react@353c30252 )**: Hold host functions in var ([#25741](facebook/react#25741)) //<Samuel Susla>// Changelog: [General][Changed] - React Native sync for revisions 17f6912...48b687f jest_e2e[run_all_tests] Reviewed By: rubennorte Differential Revision: D42855483 fbshipit-source-id: c244a595bb2d490a23b333c1b16d04a459ec94fc

In React 18.3.0 or newer, we must user camelCase `fetchPriority` prop to avoid "Warning: Invalid DOM property". In React 18.2.0 and older, we must use the lowercase `fetchpriority` prop to avoid "Warning: Invalid DOM property". See facebook/react#25927

Summary: This sync includes the following changes: - **[48b687fc9](facebook/react@48b687fc9 )**: [trusted types][www] Add enableTrustedTypesIntegration flag back in ([facebook#26016](facebook/react#26016)) //<an onion>// - **[9b1423cc0](facebook/react@9b1423cc0 )**: Revert "Hold host functions in var" ([facebook#26079](facebook/react#26079)) //<Samuel Susla>// - **[ce09ace9a](facebook/react@ce09ace9a )**: Improve Error Messages when Access Client References ([facebook#26059](facebook/react#26059)) //<Sebastian Markbåge>// - **[0652bdbd1](facebook/react@0652bdbd1 )**: Add flow types to Maps in ReactNativeViewConfigRegistry.js ([facebook#26064](facebook/react#26064)) //<Samuel Susla>// - **[ee8509801](facebook/react@ee8509801 )**: [cleanup] remove deletedTreeCleanUpLevel feature flag ([facebook#25529](facebook/react#25529)) //<Jan Kassens>// - **[0e31dd028](facebook/react@0e31dd028 )**: Remove findDOMNode www shim ([facebook#25998](facebook/react#25998)) //<Jan Kassens>// - **[379dd741e](facebook/react@379dd741e )**: [www] set enableTrustedTypesIntegration to false ([facebook#25997](facebook/react#25997)) //<Jan Kassens>// - **[555ece0cd](facebook/react@555ece0cd )**: Don't warn about concurrently rendering contexts if we finished rendering ([facebook#22797](facebook/react#22797)) //<Sebastian Silbermann>// - **[0fce6bb49](facebook/react@0fce6bb49 )**: [cleanup] remove feature flags warnAboutDefaultPropsOnFunctionComponents and warnAboutStringRefs ([facebook#25980](facebook/react#25980)) //<Jan Kassens>// - **[7002a6743](facebook/react@7002a6743 )**: [cleanup] remove unused values from ReactFeatureFlags.www-dynamic ([facebook#25575](facebook/react#25575)) //<Jan Kassens>// - **[a48e54f2b](facebook/react@a48e54f2b )**: [cleanup] remove old feature flag warnAboutDeprecatedLifecycles ([facebook#25978](facebook/react#25978)) //<Jan Kassens>// - **[0f4a83596](facebook/react@0f4a83596 )**: Remove duplicate JSResourceReferenceImpl mock ([facebook#25976](facebook/react#25976)) //<Jan Kassens>// - **[c49131669](facebook/react@c49131669 )**: Remove unused Flow suppressions ([facebook#25977](facebook/react#25977)) //<Jan Kassens>// - **[afe6521](facebook/react@afe6521e1 )**: Refactor: remove useless parameter ([facebook#25923](facebook/react#25923)) //<Chris>// - **[34464fb16](facebook/react@34464fb16 )**: Upgrade to Flow 0.196.3 ([facebook#25974](facebook/react#25974)) //<Jan Kassens>// - **[e2424f33b](facebook/react@e2424f33b )**: [flow] enable exact_empty_objects ([facebook#25973](facebook/react#25973)) //<Jan Kassens>// - **[0b4f44302](facebook/react@0b4f44302 )**: [flow] enable enforce_local_inference_annotations ([facebook#25921](facebook/react#25921)) //<Jan Kassens>// - **[0b974418c](facebook/react@0b974418c )**: [Fizz] Fork Fizz instruction set for inline script and external runtime ([facebook#25862](facebook/react#25862)) //<mofeiZ>// - **[5379b6123](facebook/react@5379b6123 )**: Batch sync, default and continuous lanes ([facebook#25700](facebook/react#25700)) //<Tianyu Yao>// - **[bbf4d2211](facebook/react@bbf4d2211 )**: Update import for babel-code-frame in build script ([facebook#25963](facebook/react#25963)) //<Ming Ye>// - **[b83baf63f](facebook/react@b83baf63f )**: Transform updates to support Flow this annotation syntax ([facebook#25918](facebook/react#25918)) //<Jan Kassens>// - **[c2d655207](facebook/react@c2d655207 )**: Unify `use` and `renderDidSuspendDelayIfPossible` implementations ([facebook#25922](facebook/react#25922)) //<Andrew Clark>// - **[48274a43a](facebook/react@48274a43a )**: Remove vestigial Suspense batching logic ([facebook#25861](facebook/react#25861)) //<Andrew Clark>// - **[de7d1c907](facebook/react@de7d1c907 )**: Add `fetchPriority` to `<img>` and `<link>` ([facebook#25927](facebook/react#25927)) //<Steven>// - **[81d4ee9ca](facebook/react@81d4ee9ca )**: reconciler docs: fix small typo - "mode" (instead of "node") ([facebook#25863](facebook/react#25863)) //<satelllte>// - **[5fcf1a4b4](facebook/react@5fcf1a4b4 )**: Bugfix: Synchronous ping during render phase sometimes unwinds the stack, leading to crash ([facebook#25851](facebook/react#25851)) //<Andrew Clark>// - **[2b1fb91a5](facebook/react@2b1fb91a5 )**: ESLint upgrade to use hermes-eslint ([facebook#25915](facebook/react#25915)) //<Jan Kassens>// - **[fabef7a6b](facebook/react@fabef7a6b )**: Resubmit Add HydrationSyncLane ([facebook#25878](facebook/react#25878)) //<Tianyu Yao>// - **[7efa9e597](facebook/react@7efa9e597 )**: Fix unwinding context during selective hydration ([facebook#25876](facebook/react#25876)) //<Tianyu Yao>// - **[84a0a171e](facebook/react@84a0a171e )**: Rename experimental useEvent to useEffectEvent ([facebook#25881](facebook/react#25881)) //<Sebastian Markbåge>// - **[4dda96a40](facebook/react@4dda96a40 )**: [react-www] remove forked bundle ([facebook#25866](facebook/react#25866)) //<Jan Kassens>// - **[9c09c1cd6](facebook/react@9c09c1cd6 )**: Revert "Fork ReactDOMSharedInternals for www ([facebook#25791](facebook/react#25791))" ([facebook#25864](facebook/react#25864)) //<lauren>// - **[996e4c0d5](facebook/react@996e4c0d5 )**: Offscreen add attach ([facebook#25603](facebook/react#25603)) //<Samuel Susla>// - **[b14d7fa4b](facebook/react@b14d7fa4b )**: Add support for setNativeProps to Fabric ([facebook#25737](facebook/react#25737)) //<Samuel Susla>// - **[819687279](facebook/react@819687279 )**: [Float] Fix typo in ReactDOMResourceValidation.js ([facebook#25798](facebook/react#25798)) //<Ikko Ashimine>// - **[5dfc485f6](facebook/react@5dfc485f6 )**: fix tests for when float is off ([facebook#25839](facebook/react#25839)) //<Josh Story>// - **[bfcbf3306](facebook/react@bfcbf3306 )**: toString children of title ([facebook#25838](facebook/react#25838)) //<Sebastian Markbåge>// - **[d4bc16a7d](facebook/react@d4bc16a7d )**: Revert "[react-www] remove forked bundle" ([facebook#25837](facebook/react#25837)) //<Ricky>// - **[d69b2cf82](facebook/react@d69b2cf82 )**: [bug fix] revert values in ReactFiberFlags to keep consistency for devtools ([facebook#25832](facebook/react#25832)) //<Mengdi Chen>// - **[645ae2686](facebook/react@645ae2686 )**: [react-www] remove forked bundle ([facebook#25831](facebook/react#25831)) //<Jan Kassens>// - **[d807eb52c](facebook/react@d807eb52c )**: Revert recent hydration changes ([facebook#25812](facebook/react#25812)) //<Andrew Clark>// - **[2ccfa657d](facebook/react@2ccfa657d )**: Fork ReactDOMSharedInternals for www ([facebook#25791](facebook/react#25791)) //<lauren>// - **[f0534ae94](facebook/react@f0534ae94 )**: Avoid replaying SelectiveHydrationException in dev ([facebook#25754](facebook/react#25754)) //<Tianyu Yao>// - **[7fab379d8](facebook/react@7fab379d8 )**: fix link to ReactDOMHostconfig in reconciler docs ([facebook#25788](facebook/react#25788)) //<Dmitry>// - **[500c8aa08](facebook/react@500c8aa08 )**: Add component name to StrictMode error message ([facebook#25718](facebook/react#25718)) //<Samuel Susla>// - **[353c30252](facebook/react@353c30252 )**: Hold host functions in var ([facebook#25741](facebook/react#25741)) //<Samuel Susla>// Changelog: [General][Changed] - React Native sync for revisions 17f6912...48b687f jest_e2e[run_all_tests] Reviewed By: rubennorte Differential Revision: D42855483 fbshipit-source-id: c244a595bb2d490a23b333c1b16d04a459ec94fc

cseas · 2023-06-16T06:05:57Z

Which versions was this fix released in? I can't find a reference of this pull request in the Changelog.

LiamWinterton · 2023-08-04T14:26:22Z

Which versions was this fix released in? I can't find a reference of this pull request in the Changelog.

I don't think it was, but I'm very much looking forward to it being introduced.

harshityadav-groww · 2024-03-29T00:02:44Z

Yes, I am facing the same problem. The <link> and <img> tags does not recognise this fetchPriority prop at all. What is the workaround for it? How can I increase the priority of the same?
I am using the prop/attribute to improve LCP in my website

nibblesnbits · 2024-04-29T06:12:33Z

Yes, I am facing the same problem. The <link> and <img> tags does not recognise this fetchPriority prop at all. What is the workaround for it? How can I increase the priority of the same? I am using the prop/attribute to improve LCP in my website

This doesn't seem to be working with a combo of Next 14.2.3 and React 18.3.0. I feel like https://github.com/vercel/next.js/blob/c24987b06fd812f13ae7780290d827dc85f056ad/packages/next/src/client/image-component.tsx#L174 isn't branching properly, maybe?

dkelly93 · 2024-04-29T10:55:42Z

Having the same issue with the same Next and React versions as @nibblesnbits

mighty6ft5max · 2024-04-29T12:23:49Z

Exists with react 18.3 and next 13.0.0

henningsieh · 2024-04-30T03:12:59Z

Yes, I am facing the same problem. The <link> and <img> tags does not recognise this fetchPriority prop at all. What is the workaround for it? How can I increase the priority of the same? I am using the prop/attribute to improve LCP in my website

This doesn't seem to be working with a combo of Next 14.2.3 and React 18.3.0. I feel like https://github.com/vercel/next.js/blob/c24987b06fd812f13ae7780290d827dc85f056ad/packages/next/src/client/image-component.tsx#L174 isn't branching properly, maybe?

Great to here, I'm not alone.

I am also on Next 14.2.3 and yesterday I updated React from 18.2 to 18.3.

This results in the following error/warnign message in dev environment:
React does not recognize thefetchPriorityprop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercasefetchpriority instead.

I do NOT use fetchpriority anywhere in my code. (I hope this is NOT because of me using the Mantine UI framework in version 6 instead of 7.)

Is there any idea what to do?

perryharlock · 2024-04-30T13:41:09Z

Yup same issue here. Next 14.2.3 and React 18.3.1. I'm using Image from next/image and not specifying fetchPriority so something is amiss. (I don't think this is anything to do with Mantine UI framework as I am not using this @henningsieh )

React 18.2.0 does not produce this warning.

jacktrusler · 2024-04-30T20:58:14Z

I think the issue comes from this piece of code in nextjs and then on line 215 when the dynamic props get spread into the element.

https://github.com/vercel/next.js/blob/029d1da22835b1e313c291cd808f9d7393adcb2d/packages/next/src/client/image-component.tsx#L168C1-L184C1

My solution was yarn add --exact [email protected] to just downgrade from 18.3.0 to 18.2.0 and the problem seems to be resolved. More context, i'm using next 13.5.6

In a previous PR, #47302, detection for `fetchPriority` assumed that facebook/react#25927 would land in [email protected] because that was the react@canary version at the time. However, it didn't land in [email protected] and it is expected to land in [email protected] due to the breaking change. This means that users upgrading to [email protected] will see a warning. The fix is to stop looking at the `React.version` string and instead check for `React.use`, a feature that [will land in [email protected]](https://react.dev/blog/2024/04/25/react-19#new-feature-use) but is also available in react@canary and react@beta today. Note: There were tests added for App Router and Pages Router in a previous PR #47302 but they seem to run on [email protected] which is why we don't see failures. Fixes #65161

facebook-github-bot added the CLA Signed label Dec 22, 2022

Add fetchPriority to <img> and <link>

ae25547

styfle force-pushed the add-fetch-priority branch from 5493c06 to ae25547 Compare December 22, 2022 21:41

sebmarkbage requested a review from eps1lon December 22, 2022 21:42

styfle marked this pull request as ready for review December 22, 2022 22:08

eps1lon mentioned this pull request Dec 23, 2022

Bug: SSR of malformed? meta renders nothing(working in 18.2) #25928

Open

eps1lon reviewed Dec 23, 2022

View reviewed changes

fixtures/attribute-behavior/src/attributes.js Outdated Show resolved Hide resolved

Polish fixture

dcccbe9

1. always read correct property (to test compat with lowercase prop name) 1. use a known string value to test read/write parity Ran fixture with meta tags enabled in Chrome Version 107.0.5304.110 (Official Build) (64-bit) on Ubuntu 22.04

eps1lon approved these changes Dec 23, 2022

View reviewed changes

styfle commented Dec 23, 2022

View reviewed changes

sebmarkbage merged commit de7d1c9 into facebook:main Dec 23, 2022

styfle deleted the add-fetch-priority branch December 23, 2022 19:39

styfle mentioned this pull request Mar 19, 2023

fix: handle different cases of React fetchPriority vercel/next.js#47302

Merged

sammy-SC mentioned this pull request Apr 5, 2023

Use native scheduler if defined sammy-SC/react#1

Closed

Netail mentioned this pull request Aug 8, 2023

feat: fetchPriority on for react image props DefinitelyTyped/DefinitelyTyped#66317

Closed

17 tasks

oliviertassinari mentioned this pull request Sep 11, 2023

Add fetchpriority to props emotion-js/emotion#3093

Open

4 tasks

jlarmstrongiv mentioned this pull request Jan 4, 2024

Warning: React does not recognize the fetchPriority prop on a DOM element ascorbic/unpic-img#425

Closed

eps1lon mentioned this pull request Apr 3, 2024

Bug: support fetchPriority in camel-case on DOM nodes. #27233

Closed

SevereCloud mentioned this pull request Apr 21, 2024

[Fix] no-unknown-property: add fetchPriority jsx-eslint/eslint-plugin-react#3697

Merged

ascorbic mentioned this pull request Apr 28, 2024

fix(react): handle fetchpriority vs fetchPriority ascorbic/unpic-img#644

Merged

ascorbic mentioned this pull request Apr 29, 2024

[React 19] React warns about "fetchpriority" props #28946

Open

styfle mentioned this pull request May 1, 2024

fix(next/image): detect react@19 for fetchPriority prop vercel/next.js#65235

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `fetchPriority` to `<img>` and `<link>` #25927

Add `fetchPriority` to `<img>` and `<link>` #25927

styfle commented Dec 22, 2022 •

edited by eps1lon

eps1lon left a comment

eps1lon commented Dec 23, 2022

styfle Dec 23, 2022 •

edited

eps1lon Dec 23, 2022

cseas commented Jun 16, 2023

LiamWinterton commented Aug 4, 2023

harshityadav-groww commented Mar 29, 2024 •

edited

nibblesnbits commented Apr 29, 2024

dkelly93 commented Apr 29, 2024

mighty6ft5max commented Apr 29, 2024

henningsieh commented Apr 30, 2024 •

edited

perryharlock commented Apr 30, 2024 •

edited

jacktrusler commented Apr 30, 2024 •

edited

Add fetchPriority to <img> and <link> #25927

Add fetchPriority to <img> and <link> #25927

Conversation

styfle commented Dec 22, 2022 • edited by eps1lon

Summary

How did you test this change?

eps1lon left a comment

Choose a reason for hiding this comment

eps1lon commented Dec 23, 2022

styfle Dec 23, 2022 • edited

Choose a reason for hiding this comment

eps1lon Dec 23, 2022

Choose a reason for hiding this comment

cseas commented Jun 16, 2023

LiamWinterton commented Aug 4, 2023

harshityadav-groww commented Mar 29, 2024 • edited

nibblesnbits commented Apr 29, 2024

dkelly93 commented Apr 29, 2024

mighty6ft5max commented Apr 29, 2024

henningsieh commented Apr 30, 2024 • edited

perryharlock commented Apr 30, 2024 • edited

jacktrusler commented Apr 30, 2024 • edited

Add `fetchPriority` to `<img>` and `<link>` #25927

Add `fetchPriority` to `<img>` and `<link>` #25927

styfle commented Dec 22, 2022 •

edited by eps1lon

styfle Dec 23, 2022 •

edited

harshityadav-groww commented Mar 29, 2024 •

edited

henningsieh commented Apr 30, 2024 •

edited

perryharlock commented Apr 30, 2024 •

edited

jacktrusler commented Apr 30, 2024 •

edited