Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BUILD_EXCLUDE_BABEL_REGISTER #44387

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented May 2, 2024

Summary: Cleaning up this env, which became redundant after D56762162. We do, however still check if running under Jest to skip inline transpilation if process.env.JEST_WORKER_ID exists.

Differential Revision: D56879413

blakef and others added 3 commits May 2, 2024 05:46
Summary:
Packages that are built and directly run in the monorepo no longer need to worry about
conditionally registering themselves to transpile Flow -> JS at runtime. Our build step
strips this file now.

Differential Revision: D56839521
Summary:
Conform to the style of other packages that are build using the monorepo build script.

Changelog: [Internal]

Differential Revision: D56879279
Summary: Cleaning up this env, which became redundant after D56762162.  We do, however still check if running under Jest to skip inline transpilation if [process.env.JEST_WORKER_ID](https://jestjs.io/docs/environment-variables#jest_worker_id) exists.

Differential Revision: D56879413
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56879413

Copy link

github-actions bot commented May 2, 2024

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 120b193

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,527,885 -2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,900,320 -13
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b38f80a
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants