Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI builds are broken #821

Open
vthemelis opened this issue Mar 31, 2024 · 0 comments
Open

CI builds are broken #821

vthemelis opened this issue Mar 31, 2024 · 0 comments

Comments

@vthemelis
Copy link
Contributor

Have a look at the GitHub actions that run for any PR and most of them seem broken.
@cclauss cclauss mentioned this issue Apr 24, 2024
Closed
2 tasks
facebook-github-bot pushed a commit that referenced this issue Apr 25, 2024
@cclauss @facebook-github-bot
Run GitHub Actions tests on current versions of Python (#832)
714c268 
Summary:
**Pre-submission checklist**
- [ ] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [ ] `pre-commit run`

Related to:
* #827
* #821
* #816

PEP 604 – Allow writing union types as `X | Y` -- https://peps.python.org/pep-0604
```
   File "/home/runner/work/pyre-check/pyre-check/client/language_server/protocol.py", line 365, in Diagnostic
    code: Optional[int | str] = None
TypeError: unsupported operand type(s) for |: 'type' and 'type'
```
On Python < 3.10 the tests are failing on PEP 604 type annotations which will be enforced by `ruff rule UP007`.
* https://docs.astral.sh/ruff/rules/non-pep604-annotation/#pyupgrade-up

On Python < 3.10 the source file ***must*** start with `from __future__ import annotations` to be able to use PEP 604 syntax.

Pull Request resolved: #832

Reviewed By: stroxler

Differential Revision: D56535593

Pulled By: migeed-z

fbshipit-source-id: 27b470c5cd16752615a16f1665a8366891e4bcc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vthemelis