Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): fix details element accessibility/search #10057

Closed
wants to merge 1 commit into from
Closed

fix(theme): fix details element accessibility/search #10057

wants to merge 1 commit into from

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 18, 2024 •
edited

Motivation

Fix #10055

Details are natively searcheable so our animated progressively enhanced version should rather keep this behavior

Test Plan

???

Test links

https://deploy-preview-10057--docusaurus-2.netlify.app/docs/markdown-features

https://deploy-preview-10057--docusaurus-2.netlify.app/tests/pages/markdown-tests-mdx#details

@slorber slorber added pr: bug fix This PR fixes a bug in a past release. domain: a11y Related to accessibility concerns of the default theme labels Apr 18, 2024
@slorber slorber requested a review from Josh-Cena as a code owner April 18, 2024 13:55
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 18, 2024
@slorber slorber marked this pull request as draft April 18, 2024 13:56
@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024

✅ [V2]

Name Link
🔨 Latest commit 63e81cb
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6621264877e1fe0009c2c465
😎 Deploy Preview https://deploy-preview-10057--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slorber slorber mentioned this pull request Apr 18, 2024
Open
7 tasks
@github-actions GitHub Actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 56 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 61 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 60 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

@github-actions GitHub Actions
Copy link

Size Change: -15 B (0%)

Total Size: 1.59 MB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/codeTranslations.json 2 B 0 B
website/.docusaurus/docusaurus.config.mjs 26.7 kB 0 B
website/.docusaurus/globalData.json 91.2 kB 0 B
website/.docusaurus/i18n.json 930 B 0 B
website/.docusaurus/registry.js 247 kB 0 B
website/.docusaurus/routes.js 156 kB 0 B
website/.docusaurus/routesChunkNames.json 109 kB 0 B
website/.docusaurus/site-metadata.json 2.17 kB 0 B
website/build/assets/css/styles.********.css 113 kB -16 B (0%)
website/build/assets/js/main.********.js 808 kB +1 B (0%)
website/build/index.html 38 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator Author

slorber commented Apr 18, 2024

doesn't really work yet 😅 I'll open another PR if I can find a solution

Note a workaround has been shared here: #10055 (comment)

@slorber slorber closed this Apr 18, 2024
@Josh-Cena Josh-Cena deleted the slorber/fix-details-accessible-search branch April 22, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA domain: a11y Related to accessibility concerns of the default theme pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Details elements aren't searchable - a11y issue
2 participants
@slorber @facebook-github-bot