Skip to content

Toolchain rules don't consistently use attrs.arg() #892

Closed
@Ralith

Description

@Ralith

Compare:

"link_flags": attrs.list(attrs.string(), default = []),

"rustc_flags": attrs.list(attrs.string(), default = []),

"linker_flags": attrs.default_only(attrs.list(attrs.arg(), default = [])),

Encountered this while trying to work around facebookincubator/reindeer#62 by referencing a filegroup's location in a toolchain's linker args. It's also weird that system_cxx_toolchain uses link_flags where linker_flags is common elsewhere. Copy-pasting the toolchain definitions and adjusting the attr types seems to work fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions