Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Deprecate "duration" kind #2179

Open
5 of 9 tasks
kwk opened this issue Jul 24, 2018 · 3 comments
Open
5 of 9 tasks

Deprecate "duration" kind #2179

kwk opened this issue Jul 24, 2018 · 3 comments
Assignees

Comments

@kwk
Copy link
Collaborator

kwk commented Jul 24, 2018

A duration in Go is nothing but an int64:

“A Duration represents the elapsed time between two instants as an int64 nanosecond count. The representation limits the largest representable duration to approximately 290 years.” (source: godoc)

We don’t have a field at the moment that uses this field kind and I cannot foresee any field that might need it.

I want to remove that field kind because it is not used and more importantly because we cannot store int64 numbers in JSONB as that only can handle IEEE-754 double precision floating point values. So we eventually will reach a point at which we do loose precision.

Approval requested from:

Please check your name if you're fine with the removal.

@bartoszmajsak
Copy link
Contributor

@kwk why so many assignees?

@kwk
Copy link
Collaborator Author

kwk commented Jul 24, 2018

@kwk why so many assignees?

@bartoszmajsak I've added a checkbox list where you can toggle your name if you approve the removal.

@bartoszmajsak
Copy link
Contributor

Clear, so that's an approval process. Well... for me it's simple - YAGNI so I approve :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants