add parameterized types #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the parser and type model to handle parameterized types such as `sequence`, `record`, `FrozenArray`, and `Promise`. Updated validation logic to recognize these types and parse their parameters correctly. Adjusted the `IdlType` class to store parameterized type information.
Renamed parameters and improved variable naming to enhance readability. Adjusted error messaging to align with updated parameter names for better context.
Previously, all imports were processed without regard for parameterized types, potentially causing issues. This update adds a filter to exclude unsupported parameterized types, improving stability and error handling. A TODO comment is included for future support of these types.
Previously, the tested interface contained 2 attributes, but this has been updated to 7. The change aligns the test with the updated interface definition.
ygdrasil-io
force-pushed
the
feature/add-parameterized-types
branch
from
6cd5199 to
5def144
Compare
Corrected inconsistent indentation in the lambda to improve code readability. This change does not alter functionality but ensures the code adheres to proper formatting standards.
Removed unnecessary conditional block checking for parameterized types within angled brackets. Simplifies code by consolidating checks and reducing duplication, improving maintainability.
fabmax
reviewed
Feb 17, 2025
| } | ||
|
|
||
| val typeParams = typeName.substring(typeName.indexOf("<") + 1, typeName.lastIndexOf(">")) | ||
| typeName = typeName.substring(0, typeName.indexOf("<")) |
There was a problem hiding this comment.
Personally, I prefer using the substringBefore / substringAfter functions for these kind of things. E.g. something like this:
val typeParams = typeName.substringAfter('<').substringBeforeLast('>')
typeName = typeName.substringBefore('<')
But that's only a personal preference so feel free to keep it this way 😄
There was a problem hiding this comment.
I agree, that part lack also of Unit Test on the result, working on it.
Refactor type parameter extraction to use more concise Kotlin functions `substringAfter` and `substringBeforeLast`.
Updated `IdlType.parameterType` from a single string to a list to handle multiple type parameters. Adjusted parsing logic in `WebIdlStream` and updated tests to validate the new structure. Ensures compatibility with complex type definitions like `record` and `FrozenArray`.
Renamed the `parameterType` field to `parameterTypes` in the `IdlType` class for consistency and clarity. Updated relevant test assertions to reflect this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.