Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interface includes and USVString type #4

Merged
merged 7 commits into from
Feb 16, 2025

Conversation

ygdrasil-io
Copy link
Contributor

No description provided.

Introduce handling of mixin interfaces and the "includes" keyword for WebIDL parsing. Updated models and parsers to differentiate between regular interfaces and mixins, ensuring proper validation for "implements" and "includes" usage. Added corresponding tests to verify the new functionality.
This update ensures that build and test output files in nested webidl-util directories are ignored by Git. It helps keep the repository clean and prevents unnecessary files from being tracked.
Updated the WebIDL model to recognize USVString as a string type alongside DOMString. Modified code generation logic to handle USVString in JNI, Java, and Kotlin/JS mappings appropriately, ensuring correct type translations and return handling.
@ygdrasil-io ygdrasil-io mentioned this pull request Feb 16, 2025
16 tasks
@ygdrasil-io ygdrasil-io marked this pull request as ready for review February 16, 2025 19:18
@ygdrasil-io ygdrasil-io changed the title add interface includes add interface includes and USVString type Feb 16, 2025
@fabmax
Copy link
Owner

fabmax commented Feb 16, 2025

Actually I wouldn't mind .gitignoring the build and test_output dirs. It used to be that way before I moved stuff into sub-projects.

Oh and it would probably be a good idea to bump the version in the build.gradle.kts to something like 0.10.0-SNAPSHOT or so to avoid confusing the codebase with the already published version.

@ygdrasil-io
Copy link
Contributor Author

Actually I wouldn't mind .gitignoring the build and test_output dirs. It used to be that way before I moved stuff into sub-projects.

Oh and it would probably be a good idea to bump the version in the build.gradle.kts to something like 0.10.0-SNAPSHOT or so to avoid confusing the codebase with the already published version.

done

@fabmax fabmax merged commit cb517e6 into fabmax:main Feb 16, 2025
2 checks passed
@ygdrasil-io ygdrasil-io deleted the feature/add-interface-includes branch February 16, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants