Add support for parsing and modeling WebIDL dictionaries #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced new parsing logic and models to handle WebIDL dictionaries, including members, default values, and required attributes. Updated tests to validate dictionary parsing and integrated dictionaries into the broader WebIDL model. Minor refactoring in related components to support the new functionality.
This workflow supports multiple OS environments (macOS, Ubuntu, and Windows) and is triggered on pushes, pull requests, or manual dispatch. It sets up JDK, caches Gradle dependencies, and runs build and check tasks to ensure code quality.
macOS testing is excluded from the matrix to address compatibility issues with the current JDK version. It can be re-added once the project upgrades to JDK 17.
The finishModel function now requires a non-null parentInterface, improving type safety. This ensures that parentModel assignment is always valid and avoids potential null checks.
Reordered the assignments to ensure `parentInterface` is set after `parentModel`. This helps maintain proper initialization sequence and avoids potential inconsistencies.
Simplify method calls in `finishModel()` by removing redundant parameter labels. Restructure `addAttribute` and `addFunction` for better readability and consistency. No functional changes introduced.
|
Looks fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new parsing logic and models to handle WebIDL dictionaries, including members, default values, and required attributes. Updated tests to validate dictionary parsing and integrated dictionaries into the broader WebIDL model. Minor refactoring in related components to support the new functionality.
I also added github test workflow.
related to #2