Skip to content

Commit 153f3de

Browse files
IsaacDurandjohnpapa
authored andcommitted
Render image of controller code inline (johnpapa#837)
* Render image of controller code inline * Render image of factory code inline * Prevent notes from rendering as code blocks
1 parent 54b8a8a commit 153f3de

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

a1/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ While this guide explains the *what*, *why* and *how*, I find it helpful to see
489489
}
490490
```
491491

492-
![Controller Using "Above the Fold"](https://raw.githubusercontent.com/johnpapa/angular-styleguide/master/a1/assets/above-the-fold-1.png)
492+
![Controller Using "Above the Fold"](https://raw.githubusercontent.com/johnpapa/angular-styleguide/master/a1/assets/above-the-fold-1.png)
493493

494494
Note: If the function is a 1 liner consider keeping it right up top, as long as readability is not affected.
495495

@@ -834,7 +834,7 @@ While this guide explains the *what*, *why* and *how*, I find it helpful to see
834834

835835
This way bindings are mirrored across the host object, primitive values cannot update alone using the revealing module pattern.
836836

837-
![Factories Using "Above the Fold"](https://raw.githubusercontent.com/johnpapa/angular-styleguide/master/a1/assets/above-the-fold-2.png)
837+
![Factories Using "Above the Fold"](https://raw.githubusercontent.com/johnpapa/angular-styleguide/master/a1/assets/above-the-fold-2.png)
838838

839839
### Function Declarations to Hide Implementation Details
840840
###### [Style [Y053](#style-y053)]
@@ -980,7 +980,7 @@ While this guide explains the *what*, *why* and *how*, I find it helpful to see
980980
}
981981
```
982982

983-
Note: The data service is called from consumers, such as a controller, hiding the implementation from the consumers, as shown below.
983+
Note: The data service is called from consumers, such as a controller, hiding the implementation from the consumers, as shown below.
984984

985985
```javascript
986986
/* recommended */
@@ -1153,7 +1153,7 @@ While this guide explains the *what*, *why* and *how*, I find it helpful to see
11531153
}
11541154
```
11551155

1156-
Note: There are many naming options for directives, especially since they can be used in narrow or wide scopes. Choose one that makes the directive and its file name distinct and clear. Some examples are below, but see the [Naming](#naming) section for more recommendations.
1156+
Note: There are many naming options for directives, especially since they can be used in narrow or wide scopes. Choose one that makes the directive and its file name distinct and clear. Some examples are below, but see the [Naming](#naming) section for more recommendations.
11571157

11581158
### Manipulate DOM in a Directive
11591159
###### [Style [Y072](#style-y072)]
@@ -1314,7 +1314,7 @@ While this guide explains the *what*, *why* and *how*, I find it helpful to see
13141314
<div>min={{vm.min}}<input ng-model="vm.min"/></div>
13151315
```
13161316

1317-
Note: You can also name the controller when you inject it into the link function and access directive attributes as properties of the controller.
1317+
Note: You can also name the controller when you inject it into the link function and access directive attributes as properties of the controller.
13181318

13191319
```javascript
13201320
// Alternative to above example
@@ -1489,7 +1489,7 @@ While this guide explains the *what*, *why* and *how*, I find it helpful to see
14891489
}
14901490
```
14911491

1492-
Note: The example below shows the route resolve points to a named function, which is easier to debug and easier to handle dependency injection.
1492+
Note: The example below shows the route resolve points to a named function, which is easier to debug and easier to handle dependency injection.
14931493

14941494
```javascript
14951495
/* even better */
@@ -1526,7 +1526,7 @@ While this guide explains the *what*, *why* and *how*, I find it helpful to see
15261526
vm.movies = moviesPrepService.movies;
15271527
}
15281528
```
1529-
Note: The code example's dependency on `movieService` is not minification safe on its own. For details on how to make this code minification safe, see the sections on [dependency injection](#manual-annotating-for-dependency-injection) and on [minification and annotation](#minification-and-annotation).
1529+
Note: The code example's dependency on `movieService` is not minification safe on its own. For details on how to make this code minification safe, see the sections on [dependency injection](#manual-annotating-for-dependency-injection) and on [minification and annotation](#minification-and-annotation).
15301530

15311531
**[Back to top](#table-of-contents)**
15321532

0 commit comments

Comments
 (0)