Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't use a global app URL prefix #59

Closed
Preston-Landers opened this issue Jul 19, 2015 · 1 comment
Closed

can't use a global app URL prefix #59

Preston-Landers opened this issue Jul 19, 2015 · 1 comment

Comments

@Preston-Landers
Copy link

Hello, I'm trying to support a global URL prefix for my app, so that all URLs have a prefix like /myapp if needed.

If the prefix is enabled, I'm setting the publisher signature to something like: myapp/bowerstatic
If there is no prefix enabled the signature is just bowerstatic.

So when I do this, my URLs to bower resources are getting generated correctly, but the publisher tween fails to recognize and serve them. The problem appears to be that in publisher.py at line 22 it calls request.path_info_peek. This only returns the first component of the URL, so it only returns myapp when my prefix is enabled. This fails to match the publisher signature of myapp\bowerstatic so it fails to serve the file.

It would be nice if it could recognize a multi-part signature is in use and match the whole thing. I could work up a pull request.

The app is a mixture of Pyramid and a custom/legacy framework, but in theory that shouldn't matter here.

@Preston-Landers
Copy link
Author

Duplicate of #60 which has a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant