Skip to content

Conversation

@csegarragonz
Copy link
Contributor

Closes #25

@csegarragonz
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant new functionality for running and attesting applications in a bare-metal AMD SEV-SNP environment. This includes a new escrow-xput application, extensive CLI tooling in accli for managing confidential VMs (cVMs) and a new attestation service, and the core logic for SNP report verification in the attestation service itself. The changes are extensive and well-structured, particularly the cVM orchestration in accli and the caching mechanisms in the attestation service.

My review focuses on a critical security gap in the SNP attestation flow, several maintainability issues in the new application code, and opportunities to improve the robustness of the new tooling. The most critical issue is the missing validation of the SNP report's measurement, which must be addressed to ensure only trusted code is attested. Other points include removing a large amount of commented-out code and improving configuration handling in the new benchmark application.

@csegarragonz csegarragonz force-pushed the feature-escrow-func branch 3 times, most recently from d33ed5c to 739bbcc Compare November 27, 2025 16:31
@csegarragonz csegarragonz merged commit d9f1100 into main Nov 28, 2025
4 checks passed
@csegarragonz csegarragonz deleted the feature-escrow-func branch November 28, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AS: verify SNP report when running on bare metal

2 participants