Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose faabric::Message #221

Open
Shillaker opened this issue Feb 3, 2022 · 0 comments
Open

Decompose faabric::Message #221

Shillaker opened this issue Feb 3, 2022 · 0 comments

Comments

@Shillaker
Copy link
Collaborator

Shillaker commented Feb 3, 2022

The faabric::Message protobuf object is bloated now and has become a dumping ground for lots of context. Having a single message format is very convenient, and necessary because of the breadth of different types of calls we support.

I think we can refactor as follows:

  • Move all Faasm-specific flags into custom serialised contexts held in the BatchRequest::contextData field. This is what we do with OpenMP, and can be applied to all SGX- and Python-related fields on the Message.
  • Move all MPI-related fields into a nested MPI context.
  • Collect all feature flags into a nested flags object (isAsync, isStatusRequest etc.).
  • Move all batch-wide properties onto the BatchRequest, e.g. snapshotKey, appId, masterHost, executesLocally, groupId
  • Create a separate protobuf object for exec-graph data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant