Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of const std::vector<T> & with std::span<const T> in arguments #202

Open
Shillaker opened this issue Dec 21, 2021 · 0 comments

Comments

@Shillaker
Copy link
Collaborator

Shillaker commented Dec 21, 2021

Many of our APIs have a const vector passed by reference (i.e. const std::vector<T> &). We can make these APIs more flexible (i.e. able to take a wider range of arguments) if we switch to std::span<const T>. Passing a std::vector will still work so it should just be a case of changing the declarations and perhaps some of the logic related to handling the argument in the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant