Skip to content

Commit 23da49b

Browse files
authored
faasmtools: pass relaxed-simd compilation flag (#124)
* faasmtools: pass -mrelaxed-simd flag * gh: bump code version * gha: credential-less access * faasmtools: clean-up comment
1 parent d9fc3ac commit 23da49b

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

.env

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
SYSROOT_VERSION=0.4.0
2-
SYSROOT_CLI_IMAGE=faasm.azurecr.io/cpp-sysroot:0.4.0
1+
SYSROOT_VERSION=0.5.0
2+
SYSROOT_CLI_IMAGE=faasm.azurecr.io/cpp-sysroot:0.5.0
33
COMPOSE_PROJECT_NAME=cpp-dev

.github/workflows/tests.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,7 @@ jobs:
1717
if: github.event.pull_request.draft == false
1818
runs-on: ubuntu-latest
1919
container:
20-
image: faasm.azurecr.io/cpp-sysroot:0.4.0
21-
credentials:
22-
username: ${{ secrets.ACR_SERVICE_PRINCIPAL_ID }}
23-
password: ${{ secrets.ACR_SERVICE_PRINCIPAL_PASSWORD }}
20+
image: faasm.azurecr.io/cpp-sysroot:0.5.0
2421
steps:
2522
# --- Update code ---
2623
- name: "Checkout code"

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ a.out
1515

1616
# Distribution / packaging
1717
.Python
18-
build/
18+
build*/
1919
develop-eggs/
2020
dist/
2121
downloads/

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.4.0
1+
0.5.0

faasmtools/build.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
# https://reviews.llvm.org/D59281
7272
WASM_CFLAGS = [
7373
"-O3",
74-
# TODO: may want to use -mrelaxed-simd instead
74+
"-mrelaxed-simd",
7575
"-msimd128",
7676
"--sysroot={}".format(WASM_SYSROOT),
7777
"-m32",
@@ -242,6 +242,7 @@ def get_faasm_build_env_dict(is_threads=False):
242242
"atomics",
243243
"bulk-memory",
244244
"mutable-globals",
245+
"relaxed-simd",
245246
"sign-ext",
246247
"simd128",
247248
]
@@ -251,6 +252,7 @@ def get_faasm_build_env_dict(is_threads=False):
251252
linker_features = [
252253
"bulk-memory",
253254
"mutable-globals",
255+
"relaxed-simd",
254256
"sign-ext",
255257
"simd128",
256258
]

0 commit comments

Comments
 (0)