Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistant type for sourceLabels and detectorLabels #13

Open
Edouard2laire opened this issue Dec 8, 2024 · 1 comment
Open

Inconsistant type for sourceLabels and detectorLabels #13

Edouard2laire opened this issue Dec 8, 2024 · 1 comment

Comments

@Edouard2laire
Copy link

Edouard2laire commented Dec 8, 2024

Hello,

It seems there is an issue with the examples in 'Simple_Probe.snirf' with sourceLabels being a cell instead of a string array as the other labels :

jnirs = loadsnirf('neuro_run01.snirf');
class(jnirs.nirs.probe.detectorLabels) %'string'
class(jnirs.nirs.probe.sourceLabels) % 'string'
 

jnirs = loadsnirf('Simple_Probe.snirf');
class(jnirs.nirs.probe.detectorLabels) %'string'
class(jnirs.nirs.probe.sourceLabels) %'cell'

Regards,
Edoaurd

@Edouard2laire
Copy link
Author

Edouard2laire commented Feb 23, 2025

any update @fangq ?

Edit: I fixed our loader here but i guess it would be easier to always have string arrays: brainstorm-tools/brainstorm3@db134e4

Edit: i think the issue is here: https://github.com/fNIRS/snirf-samples/blob/master/basic/Simple_Probe.jnirs#L1372
i think it should be : "sourceLabels": [ "S1" ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant